fix: use correct dir converting plaintext to HTML#8248
Merged
Conversation
WofWca
approved these changes
May 15, 2026
Collaborator
WofWca
left a comment
WofWca
left a comment
There was a problem hiding this comment.
Didn't test but looks good, as far as I can tell.
See discussions at deltachat/deltachat-desktop#6379.
adbenitez
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reapplies #8227 but this time with fixed tests.
It turned out for desktop the style unicode-bidi: plaintext is needed. dir="auto" didn't work. The style only without dir attribute worked too but maybe it's better to have both. With this change deltachat/deltachat-desktop#6345 is also solved for long messages that have a "Show full message" dialog
I hope there was no other reason for 6fb2f27 then the failing CI tests