From 7f8ac37a30256e6c787f831fc45004661ffa1953 Mon Sep 17 00:00:00 2001 From: Shivam Mishra Date: Thu, 2 May 2024 21:09:08 +0530 Subject: [PATCH] feat: don't allow dropdown navigation on input focused (#9341) Co-authored-by: Sivin Varghese <64252451+iamsivin@users.noreply.github.com> --- .../components/ui/dropdown/DropdownMenu.vue | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/app/javascript/shared/components/ui/dropdown/DropdownMenu.vue b/app/javascript/shared/components/ui/dropdown/DropdownMenu.vue index 6143bd930cfc..a876de4018a2 100644 --- a/app/javascript/shared/components/ui/dropdown/DropdownMenu.vue +++ b/app/javascript/shared/components/ui/dropdown/DropdownMenu.vue @@ -36,20 +36,8 @@ export default { getKeyboardEvents() { const menuButtons = this.dropdownMenuButtons(); return { - ArrowUp: { - action: e => { - e.preventDefault(); - this.focusPreviousButton(menuButtons); - }, - allowOnFocusedInput: true, - }, - ArrowDown: { - action: e => { - e.preventDefault(); - this.focusNextButton(menuButtons); - }, - allowOnFocusedInput: true, - }, + ArrowUp: () => this.focusPreviousButton(menuButtons), + ArrowDown: () => this.focusNextButton(menuButtons), }; }, focusPreviousButton(menuButtons) {