From a3d008da06325739d1b5798dcf19f97a169f067c Mon Sep 17 00:00:00 2001 From: Sojan Jose Date: Wed, 11 Oct 2023 03:46:59 -0400 Subject: [PATCH] chore: Ensure null validation for private attribute in messages (#8085) --- app/models/message.rb | 2 +- db/migrate/20231011041615_ensure_message_private_not_null.rb | 5 +++++ db/schema.rb | 4 ++-- enterprise/app/models/response.rb | 2 +- 4 files changed, 9 insertions(+), 4 deletions(-) create mode 100644 db/migrate/20231011041615_ensure_message_private_not_null.rb diff --git a/app/models/message.rb b/app/models/message.rb index 477e9807dd59..0a6763949e7b 100644 --- a/app/models/message.rb +++ b/app/models/message.rb @@ -9,7 +9,7 @@ # content_type :integer default("text"), not null # external_source_ids :jsonb # message_type :integer not null -# private :boolean default(FALSE) +# private :boolean default(FALSE), not null # processed_message_content :text # sender_type :string # sentiment :jsonb diff --git a/db/migrate/20231011041615_ensure_message_private_not_null.rb b/db/migrate/20231011041615_ensure_message_private_not_null.rb new file mode 100644 index 000000000000..302aea22ec8f --- /dev/null +++ b/db/migrate/20231011041615_ensure_message_private_not_null.rb @@ -0,0 +1,5 @@ +class EnsureMessagePrivateNotNull < ActiveRecord::Migration[7.0] + def change + change_column_null :messages, :private, false, false + end +end diff --git a/db/schema.rb b/db/schema.rb index 759c0d325dd1..15a0b6abdf49 100644 --- a/db/schema.rb +++ b/db/schema.rb @@ -10,7 +10,7 @@ # # It's strongly recommended that you check this file into your version control system. -ActiveRecord::Schema[7.0].define(version: 2023_08_01_180936) do +ActiveRecord::Schema[7.0].define(version: 2023_10_11_041615) do # These are extensions that must be enabled in order to support this database enable_extension "pg_stat_statements" enable_extension "pg_trgm" @@ -661,7 +661,7 @@ t.integer "message_type", null: false t.datetime "created_at", precision: nil, null: false t.datetime "updated_at", precision: nil, null: false - t.boolean "private", default: false + t.boolean "private", default: false, null: false t.integer "status", default: 0 t.string "source_id" t.integer "content_type", default: 0, null: false diff --git a/enterprise/app/models/response.rb b/enterprise/app/models/response.rb index d226d650ea28..2a89af5593e0 100644 --- a/enterprise/app/models/response.rb +++ b/enterprise/app/models/response.rb @@ -6,7 +6,7 @@ # answer :text not null # embedding :vector(1536) # question :string not null -# status :integer default(0) +# status :integer default("pending") # created_at :datetime not null # updated_at :datetime not null # account_id :bigint not null