Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avatar renders an incorrect symbol if it has emoji #5184

Merged
merged 3 commits into from Aug 3, 2022

Conversation

iamsivin
Copy link
Member

@iamsivin iamsivin commented Aug 3, 2022

Pull Request Template

Fixes #5176

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Screenshot

Before After
SCR-20220803-cz5 SCR-20220803-cxr

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@pr-triage pr-triage bot added the PR: unreviewed This pull request is yet to be reviewed. label Aug 3, 2022
@pr-triage pr-triage bot added PR: partially-approved Not all reviewers have approved the PR and removed PR: unreviewed This pull request is yet to be reviewed. labels Aug 3, 2022
@pranavrajs pranavrajs merged commit f7d4f39 into develop Aug 3, 2022
@pranavrajs pranavrajs deleted the fix/avatar-emoji-rendering branch August 3, 2022 08:41
@pr-triage pr-triage bot added PR: merged The pull request is merged to another branch and removed PR: partially-approved Not all reviewers have approved the PR labels Aug 3, 2022
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR: merged The pull request is merged to another branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Avatar renders incorrect symbol if emoji is given as input
3 participants