fix: clear timers and animation frame request before component unmounts#8700
Merged
Conversation
✅ Deploy Preview for chatwoot-storybook canceled.
|
Arooba-git
force-pushed
the
fix-memory-leak
branch
from
January 13, 2024 07:30
880194f to
18ef0c0
Compare
Arooba-git
changed the title
nithindavid
approved these changes
Jan 18, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋
Thank you for this project!
We found a couple of vue components making use of timers and event listeners which were not removed upon component destruction; this could lead to memory leaks. This PR fixes the issue in some noticeable components.
We ran the test cases before and after the fixes to ensure the fixes were non-intrusive.