Always require type arguments in checked scopes. #589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sulekhark
pushed a commit
that referenced
this pull request
Jul 8, 2021
Iterate over a BoundsKey set instead of a ProgramVar* set so that the iteration order does not depend on the address of the program variables. This fixes the issue, but it is still potentially a problem that the function depends on the order it iterations over the bounds keys. It is also likely that other loops over sets of pointers exbibit this same problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously added code to allow type arguments to be omitted at some calls to generic function calls. When type arguments are omitted, void is used as the value for each type argument instead. We allowed type arguments to be omitted at calls in unchecked scopes and checked bounds_only scopes. I think the difference in behavior between different forms of checked scopes will likely be confusing, so require type arguments for all checked scopes.
Testing: