Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring / Heath Check #102

Closed
marceloboeira opened this issue Mar 12, 2018 · 1 comment
Closed

Monitoring / Heath Check #102

marceloboeira opened this issue Mar 12, 2018 · 1 comment

Comments

@marceloboeira
Copy link
Member

Considering that this would be a big part of the infrastructure (getting lots of public requests), it would be interesting to have a health check endpoint, in order to monitor the status. Even more if you consider autoscaling or anything of the sort (knowing when the pod is ready to receive traffic, or if its unhealthy and shouldn't receive much load). e.g.: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/

For even more control over the infrastructure, sending metrics to statsd would also be really awesome, in order to integrate with something like Datadog and investigate any latency with more precision.

If its something that you guys think its okay I might be willing to work on PR for both.

@zhouzhuojie
Copy link
Collaborator

PRs are welcome!

  1. for liveness check, if you want to work on it, you can start with the swagger definition of /health endpoint, and then implement it in pkg/handler
  2. for statsd, you can take a look at the new relic middleware under config/middleware.go

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants