Fix AbbreviationAsWordInName Check in Checkstyle Code. #945

checkstyle · Jun 27, 2015 · bc83a3a · bc83a3a
1 parent a360c43
commit bc83a3a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/config/checkstyle_checks.xml b/config/checkstyle_checks.xml
@@ -261,9 +261,9 @@
     <module name="TodoComment"/>
     <module name="UncommentedMain"/>
     <module name="UnnecessaryParentheses"/>
+    <module name="AbbreviationAsWordInName"/>
 
 <!--
-    <module name="AbbreviationAsWordInName"/>
     <module name="AbstractClassName"/>
     <module name="AvoidEscapedUnicodeCharacters"/>
     <module name="AvoidInlineConditionals"/>

diff --git a/config/suppressions.xml b/config/suppressions.xml
@@ -33,6 +33,10 @@
     <suppress checks="ThrowsCount"
               files="Main.java"
               lines="63"/>
+    <!-- we can not change it as, Check name is part of API (used in configurations) -->
+    <suppress checks="AbbreviationAsWordInName"
+              files="JavaNCSSCheck.java"
+              lines="40"/>
 
     <!-- Tone down the checking for test code -->
     <suppress checks="EmptyBlock" files=".*[\\/]src[\\/]test[\\/]"/>

diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/RequireThisCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/RequireThisCheck.java
@@ -120,7 +120,7 @@ public int[] getAcceptableTokens() {
     public void visitToken(DetailAST ast) {
         super.visitToken(ast);
         if (ast.getType() == TokenTypes.IDENT) {
-            processIDENT(ast);
+            processIdent(ast);
         }
     }
 
@@ -130,7 +130,7 @@ public void visitToken(DetailAST ast) {
      *
      * @param ast IDENT to check.
      */
-    private void processIDENT(DetailAST ast) {
+    private void processIdent(DetailAST ast) {
         final int parentType = ast.getParent().getType();
         switch (parentType) {
             case TokenTypes.ANNOTATION_MEMBER_VALUE_PAIR: