Issue #3763: Try to avoid non-jdk runtime exceptions in code

Author: Vladlis

config/checkstyle_checks.xml

@@ -222,7 +222,10 @@
     <module name="IllegalCatch">
         <property name="illegalClassNames" value="java.lang.Exception, java.lang.Throwable, java.lang.RuntimeException, java.lang.NullPointerException"/>
     </module>
-    <module name="IllegalInstantiation"/>
+    <module name="IllegalInstantiation">
+        <property name="classes" value="org.xml.sax.SAXException, org.xml.sax.SAXParseException, org.apache.commons.beanutils.ConversionException,
+            org.antlr.v4.runtime.misc.ParseCancellationException, antlr.RecognitionException, antlr.TokenStreamException, antlr.TokenStreamRecognitionException, antlr.ANTLRException"/>
+    </module>
     <module name="IllegalThrows"/>
     <module name="IllegalToken">
         <property name="tokens" value="LABELED_STAT"/>

src/main/java/com/puppycrawl/tools/checkstyle/ConfigurationLoader.java

@@ -436,6 +436,7 @@ else if (qName.equals(PROPERTY)) {
                         overridePropsResolver, attributes.getValue(DEFAULT));
                 }
                 catch (final CheckstyleException ex) {
+                    // -@cs[IllegalInstantiation] SAXException is in the overridden method signature
                     throw new SAXException(ex);
                 }
                 final String name = attributes.getValue(NAME);
@@ -478,6 +479,8 @@ public void endElement(String uri,
                         level = SeverityLevel.getInstance(severity);
                     }
                     catch (final CheckstyleException ex) {
+                        // -@cs[IllegalInstantiation] SAXException is in the overridden
+                        // method signature
                         throw new SAXException(
                                 "Problem during accessing '" + SEVERITY + "' attribute for "
                                         + recentModule.getName(), ex);

src/main/java/com/puppycrawl/tools/checkstyle/JavadocDetailNodeParser.java

@@ -124,7 +124,7 @@ public ParseStatus parseJavadocAsDetailNode(DetailAST javadocCommentAst) {
                                 + JAVADOC_START.length());
             result.setTree(tree);
         }
-        catch (ParseCancellationException ex) {
+        catch (ParseCancellationException | IllegalArgumentException ex) {
             // If syntax error occurs then message is printed by error listener
             // and parser throws this runtime exception to stop parsing.
             // Just stop processing current Javadoc comment.
@@ -478,13 +478,13 @@ public void syntaxError(
                 errorMessage = new ParseErrorMessage(lineNumber,
                         MSG_JAVADOC_MISSED_HTML_CLOSE, charPositionInLine, token.getText());
 
-                throw new ParseCancellationException(msg);
+                throw new IllegalArgumentException(msg);
             }
             else if (MSG_JAVADOC_WRONG_SINGLETON_TAG.equals(msg)) {
                 errorMessage = new ParseErrorMessage(lineNumber,
                         MSG_JAVADOC_WRONG_SINGLETON_TAG, charPositionInLine, token.getText());
 
-                throw new ParseCancellationException(msg);
+                throw new IllegalArgumentException(msg);
             }
             else {
                 final int ruleIndex = ex.getCtx().getRuleIndex();

src/main/java/com/puppycrawl/tools/checkstyle/api/AutomaticBean.java

@@ -315,7 +315,7 @@ public Object convert(Class type, Object value) {
                     result = CommonUtils.getUriByFilename(url);
                 }
                 catch (CheckstyleException ex) {
-                    throw new ConversionException(ex);
+                    throw new IllegalArgumentException(ex);
                 }
             }
 

src/main/java/com/puppycrawl/tools/checkstyle/checks/AbstractFormatCheck.java

@@ -113,7 +113,7 @@ private void updateRegexp(String regexpFormat, int compileFlagsParam) {
             compileFlags |= compileFlagsParam;
         }
         catch (final PatternSyntaxException ex) {
-            throw new ConversionException("unable to parse " + regexpFormat, ex);
+            throw new IllegalArgumentException("unable to parse " + regexpFormat, ex);
         }
     }
 }

src/main/java/com/puppycrawl/tools/checkstyle/checks/AbstractOptionCheck.java

@@ -21,8 +21,6 @@
 
 import java.util.Locale;
 
-import org.apache.commons.beanutils.ConversionException;
-
 import com.puppycrawl.tools.checkstyle.api.AbstractCheck;
 
 /**
@@ -64,15 +62,15 @@ protected AbstractOptionCheck(T literalDefault, Class<T> optionClass) {
     /**
      * Set the option to enforce.
      * @param optionStr string to decode option from
-     * @throws ConversionException if unable to decode
+     * @throws IllegalArgumentException if unable to decode
      */
     public void setOption(String optionStr) {
         try {
             abstractOption =
                     Enum.valueOf(optionClass, optionStr.trim().toUpperCase(Locale.ENGLISH));
         }
         catch (IllegalArgumentException iae) {
-            throw new ConversionException("unable to parse " + optionStr, iae);
+            throw new IllegalArgumentException("unable to parse " + optionStr, iae);
         }
     }
 

src/main/java/com/puppycrawl/tools/checkstyle/checks/NewlineAtEndOfFileCheck.java

@@ -25,8 +25,6 @@
 import java.util.List;
 import java.util.Locale;
 
-import org.apache.commons.beanutils.ConversionException;
-
 import com.google.common.io.Closeables;
 import com.puppycrawl.tools.checkstyle.api.AbstractFileSetCheck;
 
@@ -111,8 +109,7 @@ public void setLineSeparator(String lineSeparatorParam) {
                     .toUpperCase(Locale.ENGLISH));
         }
         catch (IllegalArgumentException iae) {
-            throw new ConversionException("unable to parse " + lineSeparatorParam,
-                iae);
+            throw new IllegalArgumentException("unable to parse " + lineSeparatorParam, iae);
         }
     }
 

src/main/java/com/puppycrawl/tools/checkstyle/checks/SuppressWarningsHolder.java

@@ -26,8 +26,6 @@
 import java.util.Locale;
 import java.util.Map;
 
-import org.apache.commons.beanutils.ConversionException;
-
 import com.puppycrawl.tools.checkstyle.api.AbstractCheck;
 import com.puppycrawl.tools.checkstyle.api.AuditEvent;
 import com.puppycrawl.tools.checkstyle.api.DetailAST;
@@ -138,7 +136,7 @@ public void setAliasList(String... aliasList) {
                     .substring(index + 1));
             }
             else if (!sourceAlias.isEmpty()) {
-                throw new ConversionException(
+                throw new IllegalArgumentException(
                     "'=' expected in alias list item: " + sourceAlias);
             }
         }

src/main/java/com/puppycrawl/tools/checkstyle/checks/annotation/AnnotationUseStyleCheck.java

@@ -301,7 +301,7 @@ private static <T extends Enum<T>> T getOption(final Class<T> enumClass,
             return Enum.valueOf(enumClass, value.trim().toUpperCase(Locale.ENGLISH));
         }
         catch (final IllegalArgumentException iae) {
-            throw new ConversionException("unable to parse " + value, iae);
+            throw new IllegalArgumentException("unable to parse " + value, iae);
         }
     }
 

src/main/java/com/puppycrawl/tools/checkstyle/checks/blocks/EmptyBlockCheck.java

@@ -21,8 +21,6 @@
 
 import java.util.Locale;
 
-import org.apache.commons.beanutils.ConversionException;
-
 import com.puppycrawl.tools.checkstyle.api.AbstractCheck;
 import com.puppycrawl.tools.checkstyle.api.DetailAST;
 import com.puppycrawl.tools.checkstyle.api.TokenTypes;
@@ -84,14 +82,14 @@ public class EmptyBlockCheck
     /**
      * Set the option to enforce.
      * @param optionStr string to decode option from
-     * @throws ConversionException if unable to decode
+     * @throws IllegalArgumentException if unable to decode
      */
     public void setOption(String optionStr) {
         try {
             option = BlockOption.valueOf(optionStr.trim().toUpperCase(Locale.ENGLISH));
         }
         catch (IllegalArgumentException iae) {
-            throw new ConversionException("unable to parse " + optionStr, iae);
+            throw new IllegalArgumentException("unable to parse " + optionStr, iae);
         }
     }