Visibility Modifier Check, updated option setter, issue #710

checkstyle · Mar 3, 2015 · de4485a · de4485a
1 parent a2f7442
commit de4485a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheck.java
@@ -293,7 +293,7 @@ public void setAllowPublicImmutableFields(boolean allow)
      * Set the list of immutable classes types names.
      * @param classNames array of immutable types short names.
      */
-    public void setImmutableClassNames(String[] classNames)
+    public void setImmutableClassCanonicalNames(String[] classNames)
     {
         immutableClassCanonicalNames = Arrays.asList(classNames);
     }

diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheckTest.java
@@ -113,7 +113,7 @@ public void testUserSpecifiedImmutableClassesList() throws Exception
     {
         final DefaultConfiguration checkConfig =
                 createCheckConfig(VisibilityModifierCheck.class);
-        checkConfig.addAttribute("immutableClassNames", "java.util.List,"
+        checkConfig.addAttribute("immutableClassCanonicalNames", "java.util.List,"
                 + "com.google.common.collect.ImmutableSet");
         final String[] expected = {
             "14:35: " + getCheckMessage(MSG_KEY, "notes"),
@@ -133,7 +133,7 @@ public void testImmutableSpecifiedSameTypeName() throws Exception
     {
         final DefaultConfiguration checkConfig =
                 createCheckConfig(VisibilityModifierCheck.class);
-        checkConfig.addAttribute("immutableClassNames",
+        checkConfig.addAttribute("immutableClassCanonicalNames",
                  "com.puppycrawl.tools.checkstyle.coding.GregorianCalendar,"
                  + "com.puppycrawl.tools.checkstyle.InetSocketAddress");
         final String[] expected = {
@@ -162,7 +162,7 @@ public void testImmutableStarImportFalseNegative() throws Exception
     {
         final DefaultConfiguration checkConfig =
                 createCheckConfig(VisibilityModifierCheck.class);
-        checkConfig.addAttribute("immutableClassNames", "java.util.Arrays");
+        checkConfig.addAttribute("immutableClassCanonicalNames", "java.util.Arrays");
         final String[] expected = {
         };
         verify(checkConfig, getPath("InputImmutableStarImport.java"), expected);
@@ -173,7 +173,8 @@ public void testImmutableStarImportNoWarn() throws Exception
     {
         final DefaultConfiguration checkConfig =
                 createCheckConfig(VisibilityModifierCheck.class);
-        checkConfig.addAttribute("immutableClassNames", "com.google.common.collect.ImmutableSet");
+        checkConfig.addAttribute("immutableClassCanonicalNames",
+                 "com.google.common.collect.ImmutableSet");
         final String[] expected = {
         };
         verify(checkConfig, getPath("InputImmutableStarImport2.java"), expected);