Skip to content

Commit f3d4337

Browse files
committed
Support annotations in TypeNameCheck
1 parent f39f224 commit f3d4337

3 files changed

Lines changed: 23 additions & 3 deletions

File tree

src/main/java/com/puppycrawl/tools/checkstyle/checks/naming/TypeNameCheck.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ public int[] getDefaultTokens()
6868
return new int[] {TokenTypes.CLASS_DEF,
6969
TokenTypes.INTERFACE_DEF,
7070
TokenTypes.ENUM_DEF,
71+
TokenTypes.ANNOTATION_DEF,
7172
};
7273
}
7374
}

src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/TypeNameCheckTest.java

Lines changed: 20 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626

2727
import com.puppycrawl.tools.checkstyle.BaseCheckTestSupport;
2828
import com.puppycrawl.tools.checkstyle.DefaultConfiguration;
29+
import com.puppycrawl.tools.checkstyle.api.TokenTypes;
2930

3031
public class TypeNameCheckTest
3132
extends BaseCheckTestSupport
@@ -69,6 +70,8 @@ public void testDefault()
6970
TypeNameCheck.DEFAULT_PATTERN),
7071
buildMesssage(7, 17, "inputHeaderEnum",
7172
TypeNameCheck.DEFAULT_PATTERN),
73+
buildMesssage(9, 23, "inputHeaderAnnotation",
74+
TypeNameCheck.DEFAULT_PATTERN),
7275
};
7376
verify(checkConfig, inputFilename, expected);
7477
}
@@ -79,7 +82,7 @@ public void testClassSpecific()
7982
{
8083
final DefaultConfiguration checkConfig =
8184
createCheckConfig(TypeNameCheck.class);
82-
checkConfig.addAttribute("tokens", "CLASS_DEF");
85+
checkConfig.addAttribute("tokens", TokenTypes.getTokenName(TokenTypes.CLASS_DEF));
8386
final String[] expected = {
8487
buildMesssage(3, 7, "inputHeaderClass",
8588
TypeNameCheck.DEFAULT_PATTERN),
@@ -93,7 +96,7 @@ public void testInterfaceSpecific()
9396
{
9497
final DefaultConfiguration checkConfig =
9598
createCheckConfig(TypeNameCheck.class);
96-
checkConfig.addAttribute("tokens", "INTERFACE_DEF");
99+
checkConfig.addAttribute("tokens", TokenTypes.getTokenName(TokenTypes.INTERFACE_DEF));
97100
final String[] expected = {
98101
buildMesssage(5, 22, "inputHeaderInterface",
99102
TypeNameCheck.DEFAULT_PATTERN),
@@ -107,14 +110,28 @@ public void testEnumSpecific()
107110
{
108111
final DefaultConfiguration checkConfig =
109112
createCheckConfig(TypeNameCheck.class);
110-
checkConfig.addAttribute("tokens", "ENUM_DEF");
113+
checkConfig.addAttribute("tokens", TokenTypes.getTokenName(TokenTypes.ENUM_DEF));
111114
final String[] expected = {
112115
buildMesssage(7, 17, "inputHeaderEnum",
113116
TypeNameCheck.DEFAULT_PATTERN),
114117
};
115118
verify(checkConfig, inputFilename, expected);
116119
}
117120

121+
@Test
122+
public void testAnnotationSpecific()
123+
throws Exception
124+
{
125+
final DefaultConfiguration checkConfig =
126+
createCheckConfig(TypeNameCheck.class);
127+
checkConfig.addAttribute("tokens", TokenTypes.getTokenName(TokenTypes.ANNOTATION_DEF));
128+
final String[] expected = {
129+
buildMesssage(9, 23, "inputHeaderAnnotation",
130+
TypeNameCheck.DEFAULT_PATTERN),
131+
};
132+
verify(checkConfig, inputFilename, expected);
133+
}
134+
118135
private String buildMesssage(int lineNumber, int colNumber, String name,
119136
String pattern)
120137
{

src/test/resources/com/puppycrawl/tools/checkstyle/naming/InputTypeName.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,6 @@ public interface inputHeaderInterface {};
66

77
public enum inputHeaderEnum { one, two };
88

9+
public @interface inputHeaderAnnotation {};
10+
911
}

0 commit comments

Comments
 (0)