Class has to be moved to subpackage "ant" to clearly show that it is not past of library.
As we host Ant extension, we need to rename this class to clealy state that is not related to library in pure meaning of term.
Rename CheckStyleTask to CheckstyleAntTask. #1108
Rename and move checkstyletask.properties. #1108
File `checkstyletask.properties` is renamed and moved to
Revert "Rename and move checkstyletask.properties. #1108"
This reverts commit e5eb542.
Checkstyle Ant Task migration while updating to Checkstyle 6.8:
Update after renaming checkstyletask. checkstyle/checkstyle#1108
ATTENTION: compatibility with gradle plugin was broken (as gradle reused CheckStyleTask class) - https://travis-ci.org/sevntu-checkstyle/checkstyle-samples , plugin has to be updated
That's quite serious incompatibility. Shouldn't we revert that commit and release as 6.8.2? We can wait for the fix on Gradle side and then bring the commit back. Moreover we should have integration test with Gradle as a lot of people use it these days.
Issue on Gradle's JIRA.
As we remove that fix, there will be incentive for community to upgrade to latest gradle, we would have to keep that fix for long time.
Old version users should stay with 6.7 .
The same incompatibility is present with Maven's checkstyle plugin.
@jsotuyod i do not think there is an incompatibility with maven-checkstyle-plugin. It does not use the CheckStyleTask class, and actually works with CS 6.8, i just tried it in a big project.
@WonderCsabo you are absolutely right, thanks!
there should be no problem, we use maven plugin in our regression testing. So we will notice any braking compatibility on PR level.
How do I get this fix into my build?
switch to latest gradle. Example that works (verified by Travis) - https://github.com/sevntu-checkstyle/checkstyle-samples/tree/master/gradle-project