Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename CheckStyleTask to CheckstyleAntTask #1108

Closed
romani opened this issue May 19, 2015 · 13 comments
Closed

rename CheckStyleTask to CheckstyleAntTask #1108

romani opened this issue May 19, 2015 · 13 comments
Labels
Milestone

Comments

@romani
Copy link
Member

@romani romani commented May 19, 2015

https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/CheckStyleTask.java

Class has to be moved to subpackage "ant" to clearly show that it is not past of library.

As we host Ant extension, we need to rename this class to clealy state that is not related to library in pure meaning of term.

@romani romani added the approved label May 19, 2015
mkordas added a commit to mkordas/checkstyle that referenced this issue May 31, 2015
mkordas added a commit to mkordas/checkstyle that referenced this issue May 31, 2015
mkordas added a commit to mkordas/checkstyle that referenced this issue May 31, 2015
mkordas added a commit to mkordas/checkstyle that referenced this issue Jun 4, 2015
mkordas added a commit to mkordas/checkstyle that referenced this issue Jun 4, 2015
mkordas added a commit to mkordas/checkstyle that referenced this issue Jun 5, 2015
mkordas added a commit to mkordas/checkstyle that referenced this issue Jun 6, 2015
mkordas added a commit to mkordas/checkstyle that referenced this issue Jun 7, 2015
mkordas added a commit to mkordas/checkstyle that referenced this issue Jun 7, 2015
mkordas added a commit to mkordas/checkstyle that referenced this issue Jun 7, 2015
mkordas added a commit to mkordas/checkstyle that referenced this issue Jun 7, 2015
File `checkstyletask.properties` is renamed and moved to
`com/puppycrawl/tools/checkstyle/ant/checkstyle-ant-task.properties`.
romani added a commit that referenced this issue Jun 7, 2015
File `checkstyletask.properties` is renamed and moved to
`com/puppycrawl/tools/checkstyle/ant/checkstyle-ant-task.properties`.
mkordas added a commit to mkordas/checkstyle that referenced this issue Jun 7, 2015
File `checkstyletask.properties` is renamed and moved to
`com/puppycrawl/tools/checkstyle/ant/checkstyle-ant-task.properties`.
romani added a commit that referenced this issue Jun 7, 2015
romani added a commit that referenced this issue Jun 7, 2015
File `checkstyletask.properties` is renamed and moved to
`com/puppycrawl/tools/checkstyle/ant/checkstyle-ant-task.properties`.
@mkordas
Copy link
Contributor

@mkordas mkordas commented Jun 7, 2015

Checkstyle Ant Task migration while updating to Checkstyle 6.8:

  • replace all occurrences of checkstyletask.properties with com/puppycrawl/tools/checkstyle/ant/checkstyle-ant-task.properties
  • replace all occurrences of antlib:com.puppycrawl.tools.checkstyle with antlib:com.puppycrawl.tools.checkstyle.ant
mkordas added a commit to mkordas/checkstyle-samples that referenced this issue Jun 7, 2015
@romani romani added this to the 6.8 milestone Jun 13, 2015
@romani
Copy link
Member Author

@romani romani commented Jun 13, 2015

merged.

@romani romani closed this Jun 13, 2015
romani added a commit to sevntu-checkstyle/checkstyle-samples that referenced this issue Jun 29, 2015
Update after renaming checkstyletask. checkstyle/checkstyle#1108
@romani
Copy link
Member Author

@romani romani commented Jul 1, 2015

ATTENTION: compatibility with gradle plugin was broken (as gradle reused CheckStyleTask class) - https://travis-ci.org/sevntu-checkstyle/checkstyle-samples , plugin has to be updated

@mkordas
Copy link
Contributor

@mkordas mkordas commented Jul 1, 2015

That's quite serious incompatibility. Shouldn't we revert that commit and release as 6.8.2? We can wait for the fix on Gradle side and then bring the commit back. Moreover we should have integration test with Gradle as a lot of people use it these days.

@WonderCsabo
Copy link
Contributor

@WonderCsabo WonderCsabo commented Jul 1, 2015

@romani
Copy link
Member Author

@romani romani commented Jul 1, 2015

As we remove that fix, there will be incentive for community to upgrade to latest gradle, we would have to keep that fix for long time.

Old version users should stay with 6.7 .

@jsotuyod
Copy link
Contributor

@jsotuyod jsotuyod commented Jul 1, 2015

The same incompatibility is present with Maven's checkstyle plugin.

https://issues.apache.org/jira/browse/MCHECKSTYLE-300

@WonderCsabo
Copy link
Contributor

@WonderCsabo WonderCsabo commented Jul 1, 2015

@jsotuyod i do not think there is an incompatibility with maven-checkstyle-plugin. It does not use the CheckStyleTask class, and actually works with CS 6.8, i just tried it in a big project.

@jsotuyod
Copy link
Contributor

@jsotuyod jsotuyod commented Jul 1, 2015

@WonderCsabo you are absolutely right, thanks!

@romani
Copy link
Member Author

@romani romani commented Jul 1, 2015

maven-checkstyle-plugin

there should be no problem, we use maven plugin in our regression testing. So we will notice any braking compatibility on PR level.

@cperry-gpsw
Copy link

@cperry-gpsw cperry-gpsw commented Oct 16, 2015

How do I get this fix into my build?

@romani
Copy link
Member Author

@romani romani commented Oct 16, 2015

switch to latest gradle. Example that works (verified by Travis) - https://github.com/sevntu-checkstyle/checkstyle-samples/tree/master/gradle-project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.