rename CheckStyleTask to CheckstyleAntTask #1108

Closed
romani opened this Issue May 19, 2015 · 13 comments

Projects

None yet

5 participants

@romani
Member
romani commented May 19, 2015

https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/CheckStyleTask.java

Class has to be moved to subpackage "ant" to clearly show that it is not past of library.

As we host Ant extension, we need to rename this class to clealy state that is not related to library in pure meaning of term.

@romani romani added the approved label May 19, 2015
@mkordas mkordas added a commit to mkordas/checkstyle that referenced this issue May 31, 2015
@mkordas mkordas Rename CheckStyleTask to CheckstyleAntTask. #1108 0659059
@mkordas mkordas added a commit to mkordas/checkstyle that referenced this issue May 31, 2015
@mkordas mkordas Rename CheckStyleTask to CheckstyleAntTask. #1108 4ea51b2
@mkordas mkordas added a commit to mkordas/checkstyle that referenced this issue May 31, 2015
@mkordas mkordas Rename CheckStyleTask to CheckstyleAntTask. #1108 bccbc34
@mkordas mkordas added a commit to mkordas/checkstyle that referenced this issue Jun 4, 2015
@mkordas mkordas Rename CheckStyleTask to CheckstyleAntTask. #1108 c26c3fd
@mkordas mkordas added a commit to mkordas/checkstyle that referenced this issue Jun 4, 2015
@mkordas mkordas Rename CheckStyleTask to CheckstyleAntTask. #1108 98170d4
@mkordas mkordas added a commit to mkordas/checkstyle that referenced this issue Jun 5, 2015
@mkordas mkordas Rename CheckStyleTask to CheckstyleAntTask. #1108 4e2305f
@mkordas mkordas added a commit to mkordas/checkstyle that referenced this issue Jun 6, 2015
@mkordas mkordas Rename CheckStyleTask to CheckstyleAntTask. #1108 ddd6cfb
@mkordas mkordas added a commit to mkordas/checkstyle that referenced this issue Jun 7, 2015
@mkordas mkordas Rename CheckStyleTask to CheckstyleAntTask. #1108 067fe72
@mkordas mkordas added a commit to mkordas/checkstyle that referenced this issue Jun 7, 2015
@mkordas mkordas Rename CheckStyleTask to CheckstyleAntTask. #1108 10aa5f4
@mkordas mkordas added a commit to mkordas/checkstyle that referenced this issue Jun 7, 2015
@mkordas mkordas Rename CheckStyleTask to CheckstyleAntTask. #1108 f9fb945
@mkordas mkordas added a commit to mkordas/checkstyle that referenced this issue Jun 7, 2015
@mkordas mkordas Rename and move checkstyletask.properties. #1108
File `checkstyletask.properties` is renamed and moved to
`com/puppycrawl/tools/checkstyle/ant/checkstyle-ant-task.properties`.
816df2d
@romani romani added a commit that referenced this issue Jun 7, 2015
@mkordas @romani mkordas + romani Rename and move checkstyletask.properties. #1108
File `checkstyletask.properties` is renamed and moved to
`com/puppycrawl/tools/checkstyle/ant/checkstyle-ant-task.properties`.
e5eb542
@mkordas mkordas added a commit to mkordas/checkstyle that referenced this issue Jun 7, 2015
@mkordas mkordas Rename and move checkstyletask.properties. #1108
File `checkstyletask.properties` is renamed and moved to
`com/puppycrawl/tools/checkstyle/ant/checkstyle-ant-task.properties`.
3efd1cf
@romani romani added a commit that referenced this issue Jun 7, 2015
@romani romani Revert "Rename and move checkstyletask.properties. #1108"
This reverts commit e5eb542.
c6b6c86
@romani romani added a commit that referenced this issue Jun 7, 2015
@mkordas @romani mkordas + romani Rename and move checkstyletask.properties. #1108
File `checkstyletask.properties` is renamed and moved to
`com/puppycrawl/tools/checkstyle/ant/checkstyle-ant-task.properties`.
4f44299
@mkordas
Member
mkordas commented Jun 7, 2015

Checkstyle Ant Task migration while updating to Checkstyle 6.8:

  • replace all occurrences of checkstyletask.properties with com/puppycrawl/tools/checkstyle/ant/checkstyle-ant-task.properties
  • replace all occurrences of antlib:com.puppycrawl.tools.checkstyle with antlib:com.puppycrawl.tools.checkstyle.ant
@mkordas mkordas added a commit to mkordas/checkstyle-samples that referenced this issue Jun 7, 2015
@mkordas mkordas Update after renaming checkstyletask. checkstyle/checkstyle#1108 3a9e6dd
@romani romani added this to the 6.8 milestone Jun 13, 2015
@romani
Member
romani commented Jun 13, 2015

merged.

@romani romani closed this Jun 13, 2015
@romani
Member
romani commented Jul 1, 2015

ATTENTION: compatibility with gradle plugin was broken (as gradle reused CheckStyleTask class) - https://travis-ci.org/sevntu-checkstyle/checkstyle-samples , plugin has to be updated

@mkordas
Member
mkordas commented Jul 1, 2015

That's quite serious incompatibility. Shouldn't we revert that commit and release as 6.8.2? We can wait for the fix on Gradle side and then bring the commit back. Moreover we should have integration test with Gradle as a lot of people use it these days.

@romani
Member
romani commented Jul 1, 2015

As we remove that fix, there will be incentive for community to upgrade to latest gradle, we would have to keep that fix for long time.

Old version users should stay with 6.7 .

@jsotuyod
Contributor
jsotuyod commented Jul 1, 2015

The same incompatibility is present with Maven's checkstyle plugin.

https://issues.apache.org/jira/browse/MCHECKSTYLE-300

@WonderCsabo
Contributor

@jsotuyod i do not think there is an incompatibility with maven-checkstyle-plugin. It does not use the CheckStyleTask class, and actually works with CS 6.8, i just tried it in a big project.

@jsotuyod
Contributor
jsotuyod commented Jul 1, 2015

@WonderCsabo you are absolutely right, thanks!

@romani
Member
romani commented Jul 1, 2015

maven-checkstyle-plugin

there should be no problem, we use maven plugin in our regression testing. So we will notice any braking compatibility on PR level.

@cperry-gpsw

How do I get this fix into my build?

@romani
Member
romani commented Oct 16, 2015

switch to latest gradle. Example that works (verified by Travis) - https://github.com/sevntu-checkstyle/checkstyle-samples/tree/master/gradle-project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment