Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SHA-1 instead on non-standard SHA in PropertyCacheFile #1251

Closed
mkordas opened this issue Jun 28, 2015 · 1 comment
Closed

Use SHA-1 instead on non-standard SHA in PropertyCacheFile #1251

mkordas opened this issue Jun 28, 2015 · 1 comment
Labels
approved
Milestone
6.8

Comments

@mkordas
Copy link
Contributor

mkordas commented Jun 28, 2015

Issue is in PropertyCacheFile.java:201.

According to http://stackoverflow.com/questions/14903539/what-specific-hash-algorithm-does-messagedigest-getinstancesha-return, SHA is non-standard one and SHA-1 should be used.
mkordas added a commit to mkordas/checkstyle that referenced this issue Jun 28, 2015
@mkordas
Use SHA-1 instead on non-standard SHA in PropertyCacheFile. checkstyl…
5a87638 
…e#1251
romani pushed a commit that referenced this issue Jun 28, 2015
@mkordas @romani
Use SHA-1 instead on non-standard SHA in PropertyCacheFile. #1251
1b5c393
@romani romani added this to the 6.8 milestone Jun 28, 2015
@romani
Copy link
Member

romani commented Jun 28, 2015

merged.

@romani romani closed this as completed Jun 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
6.8
Development

No branches or pull requests
2 participants
@romani @mkordas