Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable action lint #12678

Closed
nrmancuso opened this issue Jan 24, 2023 · 3 comments · Fixed by #12938
Closed

Re-enable action lint #12678

nrmancuso opened this issue Jan 24, 2023 · 3 comments · Fixed by #12938
Assignees
Milestone

Comments

@nrmancuso
Copy link
Member

nrmancuso commented Jan 24, 2023

Actionlint docker image does not like arguments to the container, see https://github.com/checkstyle/checkstyle/actions/runs/3998588410/jobs/6861429747:

could not read "deprecated.*'": open deprecated.*': no such file or directory


It is splitting the arguments even if we use = or enclose them in quotes. Let's disable actionlint for now to unblock restoration of diff report generation with patch config, and deal with actionlint later.

@nrmancuso nrmancuso self-assigned this Jan 24, 2023
@nrmancuso nrmancuso changed the title Remove all usages of 'set-output' command in diff_report.yml Re-enable action lint Jan 24, 2023
@nrmancuso
Copy link
Member Author

@stoyanK7 as you are github action expert, can you help with this issue?

@stoyanK7
Copy link
Collaborator

@nrmancuso Is this what you are looking for?

https://github.com/stoyanK7/checkstyle/actions/runs/4553573127/jobs/8030294702#step:4:6

.github/workflows/release-new-milestone-and-issues-in-other-repos.yml:27:92: property "concurrency-group" is not defined in object type {version: any} [expression]
.github/workflows/release-publish-releasenotes-twitter.yml:23:92: property "concurrency-group" is not defined in object type {version: any} [expression]
.github/workflows/release-update-github-io.yml:23:92: property "concurrency-group" is not defined in object type {version: any} [expression]
.github/workflows/release-update-github-page.yml:23:92: property "concurrency-group" is not defined in object type {version: any} [expression]
.github/workflows/release-upload-all-jar.yml:26:92: property "concurrency-group" is not defined in object type {version: any} [expression]

All these should work:

  • -ignore=".* was deprecated.*"
  • '-ignore ".* was deprecated.*"'
  • -ignore ".* was deprecated.*"

From https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepswithargs

A single argument that includes spaces should be surrounded by double quotes ""

@romani
Copy link
Member

romani commented Apr 1, 2023

fix is merged

Sloent pushed a commit to Sloent/checkstyle that referenced this issue Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants