Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve pitest suppression for FilterSet #12879

Closed
ThatSneakyCoder opened this issue Mar 21, 2023 · 3 comments
Closed

Resolve pitest suppression for FilterSet #12879

ThatSneakyCoder opened this issue Mar 21, 2023 · 3 comments
Labels
approved miscellaneous

Comments

@ThatSneakyCoder
Copy link
Contributor

ThatSneakyCoder commented Mar 21, 2023 •
edited

Related to #12341

Kill the surviving mutation;

checkstyle/config/pitest-suppressions/pitest-api-suppressions.xml

Lines 111 to 118 in d59b83b

<mutation unstable="false">
<sourceFile>FilterSet.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.api.FilterSet</mutatedClass>
<mutatedMethod>getFilters</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator>
<description>replaced call to java/util/Collections::unmodifiableSet with argument</description>
<lineContent>return Collections.unmodifiableSet(filters);</lineContent>
</mutation>

@ThatSneakyCoder
Copy link
Contributor Author

ThatSneakyCoder commented Mar 21, 2023 •
edited

@romani @nrmancuso
please approve

@ThatSneakyCoder ThatSneakyCoder mentioned this issue Mar 22, 2023
Merged
@ThatSneakyCoder
Copy link
Contributor Author

I'm on it.

ThatSneakyCoder added a commit to ThatSneakyCoder/checkstyle that referenced this issue Mar 22, 2023
@ThatSneakyCoder
Issue checkstyle#12879: Resolve pitest suppression for FilterSet
1d11d05
@ThatSneakyCoder ThatSneakyCoder mentioned this issue Mar 22, 2023
Merged
romani pushed a commit that referenced this issue Mar 23, 2023
@ThatSneakyCoder @romani
Issue #12879: Resolve pitest suppression for FilterSet
54ad83e
@ThatSneakyCoder
Copy link
Contributor Author

Fix is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved miscellaneous
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@romani @ThatSneakyCoder