New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move all dtd schemas to sourceforge site #1571

Closed
romani opened this Issue Aug 7, 2015 · 6 comments

Comments

Projects
None yet
4 participants
@romani
Member

romani commented Aug 7, 2015

http://www.puppycrawl.com/dtds/configuration_1_3.dtd and others dtds from configs need to be hosted at sourceforge site
all configs need to be updated

As a separate commit:
Additionally investigate ability to reuse dtd from local to avoid numerous build failures due to internet connection problems:

The plugin doesn't work in offline mode. It always tries to resolve external resources and fails, if the network is not available ?
You've got to download the resources in question once and store them as part of the project. A catalog file will replace the external resource with your local copy. See this example for details.

http://www.mojohaus.org/xml-maven-plugin/examples/catalog.html

Location of DTD - https://github.com/checkstyle/checkstyle/tree/master/src/main/resources/com/puppycrawl/tools/checkstyle

DTDs to move to "http://checkstyle.sourceforge.net/dtds/........":
Current:

<!DOCTYPE module PUBLIC
          "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
          "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">

Should be:

<!DOCTYPE module PUBLIC
          "-//Checkstyle//DTD Configuration 1.3//EN"
          "http://checkstyle.sourceforge.net/dtds/configuration_1_3.dtd">

Current:

<!DOCTYPE suppressions PUBLIC
    "-//Puppy Crawl//DTD Suppressions 1.1//EN"
    "http://www.puppycrawl.com/dtds/suppressions_1_1.dtd">

Should be:

<!DOCTYPE suppressions PUBLIC
    "-//Checkstyle//DTD Suppressions 1.1//EN"
    "http://checkstyle.sourceforge.net/dtds/suppressions_1_1.dtd">

Current:

<!DOCTYPE import-control PUBLIC
    "-//Puppy Crawl//DTD Import Control 1.1//EN"
    "http://www.puppycrawl.com/dtds/import_control_1_1.dtd">

Should be:

<!DOCTYPE import-control PUBLIC
    "-//Checkstyle//DTD Import Control 1.1//EN"
    "http://checkstyle.sourceforge.net/dtds/import_control_1_1.dtd">

Current:

<!DOCTYPE checkstyle-packages PUBLIC
    "-//Puppy Crawl//DTD Package Names 1.0//EN"
    "http://www.puppycrawl.com/dtds/packages_1_0.dtd">

Should be:

<!DOCTYPE checkstyle-packages PUBLIC
    "-//Checkstyle//DTD Package Names 1.0//EN"
    "http://checkstyle.sourceforge.net/dtds/packages_1_0.dtd">

Attention: all version of config should be uploaded to sourceforge site. There should be no reference to "puppycrawl" at any of your sources/configs/xdoc/.... .

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Nov 2, 2016

Member

@romani
The import schema was done here: #2999 (comment)
Is there any chance to get the others moved to free up the linked issues?
Is the physical move something only you can do?

Member

rnveach commented Nov 2, 2016

@romani
The import schema was done here: #2999 (comment)
Is there any chance to get the others moved to free up the linked issues?
Is the physical move something only you can do?

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Nov 2, 2016

Member

all schemes are stored in git, all we need is to change them as described , bump their versions (for all except for schema that is changed at #2999) and update our site build process to host them at new place.
Any contributor can do this.

Member

romani commented Nov 2, 2016

all schemes are stored in git, all we need is to change them as described , bump their versions (for all except for schema that is changed at #2999) and update our site build process to host them at new place.
Any contributor can do this.

@romani romani added the for-members label Nov 2, 2016

@MEZk

This comment has been minimized.

Show comment
Hide comment
@MEZk

MEZk Apr 18, 2017

Contributor

@romani
I'm on it

Contributor

MEZk commented Apr 18, 2017

@romani
I'm on it

MEZk added a commit to MEZk/checkstyle that referenced this issue Apr 23, 2017

MEZk added a commit to MEZk/checkstyle that referenced this issue Apr 23, 2017

MEZk added a commit to MEZk/checkstyle that referenced this issue Apr 26, 2017

MEZk added a commit to MEZk/checkstyle that referenced this issue Apr 26, 2017

MEZk added a commit to MEZk/checkstyle that referenced this issue Apr 30, 2017

MEZk added a commit to MEZk/checkstyle that referenced this issue Apr 30, 2017

MEZk added a commit to MEZk/checkstyle that referenced this issue Apr 30, 2017

rnveach added a commit that referenced this issue May 1, 2017

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach May 1, 2017

Member

Fix is merged.

Member

rnveach commented May 1, 2017

Fix is merged.

@rnveach rnveach closed this May 1, 2017

@rnveach rnveach added this to the 7.8 milestone May 1, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

@tsjensen

This comment has been minimized.

Show comment
Hide comment
@tsjensen

tsjensen Jul 10, 2017

Contributor

Will the current DTDs continue to be available on puppycrawl?
(New versions don't need to be, I'm just talking about existing versions.)

Contributor

tsjensen commented Jul 10, 2017

Will the current DTDs continue to be available on puppycrawl?
(New versions don't need to be, I'm just talking about existing versions.)

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 10, 2017

Member

Will the current DTDs continue to be available on puppycrawl?

yes, we will not touch them, but eventually (in far future) they could be removed or lost.

Member

romani commented Jul 10, 2017

Will the current DTDs continue to be available on puppycrawl?

yes, we will not touch them, but eventually (in far future) they could be removed or lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment