New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace line-based suppressions with inline ones for Checkstyle's suppressions.xml #2226

Closed
mkordas opened this Issue Sep 23, 2015 · 5 comments

Comments

Projects
None yet
3 participants
@mkordas
Contributor

mkordas commented Sep 23, 2015

All line-based suppressions from https://github.com/checkstyle/checkstyle/blob/checkstyle-6.10.1/config/suppressions.xml should be replaced with code-inline suppressions.

Code-inline suppressions are temporary solution until AST-based suppressions will be implemented.

Rationale - any change in the files with line-based suppressions may cause build failure even if an author was not modifying code related to suppression. Very few people will know that in such case also modification of suppressions.xml is required.

@romani romani added the approved label Sep 23, 2015

@MEZk

This comment has been minimized.

Show comment
Hide comment
@MEZk

MEZk Aug 6, 2016

Contributor

@romani
Can we provide a fix for the issue, because specifying line numbers in suppression.xml always forces us to update the file each time we perform the modification of the code and it really irritates me?

Contributor

MEZk commented Aug 6, 2016

@romani
Can we provide a fix for the issue, because specifying line numbers in suppression.xml always forces us to update the file each time we perform the modification of the code and it really irritates me?

@romani romani removed the approved label Sep 8, 2016

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Sep 8, 2016

Member

@MEZk ,

should be replaced with code-inline suppressions

I completely disagree on this, as code-inline suppression pollute code with extra comments or annotations.
We need to implement https://github.com/checkstyle/checkstyle/wiki/Checkstyle-GSoC-2016-Project-Ideas#project-name-flexible-suppression-model

But we have only 9 cases of suppression by line. So I am ok to move only them to code and create issue to remove them as soon as flexible suppression is implemented.

Member

romani commented Sep 8, 2016

@MEZk ,

should be replaced with code-inline suppressions

I completely disagree on this, as code-inline suppression pollute code with extra comments or annotations.
We need to implement https://github.com/checkstyle/checkstyle/wiki/Checkstyle-GSoC-2016-Project-Ideas#project-name-flexible-suppression-model

But we have only 9 cases of suppression by line. So I am ok to move only them to code and create issue to remove them as soon as flexible suppression is implemented.

@romani romani added the approved label Sep 8, 2016

@MEZk

This comment has been minimized.

Show comment
Hide comment
@MEZk

MEZk Sep 11, 2016

Contributor

@romani

But we have only 9 cases of suppression by line.

Why 9? We have 25 cases of suppression by line in suppressions.xml + 9 in sevntu_suppressions.xml.
Thus, what is the final decision?

Contributor

MEZk commented Sep 11, 2016

@romani

But we have only 9 cases of suppression by line.

Why 9? We have 25 cases of suppression by line in suppressions.xml + 9 in sevntu_suppressions.xml.
Thus, what is the final decision?

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Sep 11, 2016

Member

Ok , lets give it a try.
Ok to change even it is 25+9 .

Member

romani commented Sep 11, 2016

Ok , lets give it a try.
Ok to change even it is 25+9 .

MEZk added a commit to MEZk/checkstyle that referenced this issue Sep 12, 2016

MEZk added a commit to MEZk/checkstyle that referenced this issue Sep 14, 2016

MEZk added a commit to MEZk/checkstyle that referenced this issue Sep 14, 2016

MEZk added a commit to MEZk/checkstyle that referenced this issue Sep 14, 2016

romani added a commit that referenced this issue Sep 14, 2016

@romani romani added this to the 7.2 milestone Sep 14, 2016

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Sep 14, 2016

Member

fix is merged.

Member

romani commented Sep 14, 2016

fix is merged.

@romani romani closed this Sep 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment