Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Replace line-based suppressions with inline ones for Checkstyle's suppressions.xml #2226
All line-based suppressions from https://github.com/checkstyle/checkstyle/blob/checkstyle-6.10.1/config/suppressions.xml should be replaced with code-inline suppressions.
Code-inline suppressions are temporary solution until AST-based suppressions will be implemented.
Rationale - any change in the files with line-based suppressions may cause build failure even if an author was not modifying code related to suppression. Very few people will know that in such case also modification of
I completely disagree on this, as code-inline suppression pollute code with extra comments or annotations.
But we have only 9 cases of suppression by line. So I am ok to move only them to code and create issue to remove them as soon as flexible suppression is implemented.