Javadoc for try-with-resources tokens is not good enough #2899

Closed
mkordas opened this Issue Feb 11, 2016 · 6 comments

Comments

Projects
None yet
5 participants
@mkordas
Contributor

mkordas commented Feb 11, 2016

There are two different token types in TokenTypes for try-with-resources.
screenshot from 2016-02-11 20-46-20
The difference between these tokens should be explained there.

@romani romani added the approved label Feb 11, 2016

@rnveach rnveach added the easy label Mar 2, 2017

@Sukrityshrivastava

This comment has been minimized.

Show comment
Hide comment
@Sukrityshrivastava

Sukrityshrivastava Mar 13, 2017

Can you please provide some more details about what I need to do?

Can you please provide some more details about what I need to do?

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Mar 13, 2017

Member

@Sukrityshrivastava We need a clear description of the 2 tokens so users can tell what they are and their differences. Description should be clear and a bit more detailed, we should show a Java code example and a AST Tree example.

Member

rnveach commented Mar 13, 2017

@Sukrityshrivastava We need a clear description of the 2 tokens so users can tell what they are and their differences. Description should be clear and a bit more detailed, we should show a Java code example and a AST Tree example.

@Sukrityshrivastava

This comment has been minimized.

Show comment
Hide comment
@Sukrityshrivastava

Sukrityshrivastava Mar 13, 2017

Actually I am new and need help so can you please specify in which file I need to do modifications.

Actually I am new and need help so can you please specify in which file I need to do modifications.

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Mar 13, 2017

Member

@Sukrityshrivastava Changes need to be done in TokenTypes.java file as described in first post.

Member

rnveach commented Mar 13, 2017

@Sukrityshrivastava Changes need to be done in TokenTypes.java file as described in first post.

@subkrish

This comment has been minimized.

Show comment
Hide comment
@subkrish

subkrish Apr 4, 2017

Contributor

@rnveach Since @Sukrityshrivastava did not continue to work on this, I would like to take this issue over. I am on it.

Contributor

subkrish commented Apr 4, 2017

@rnveach Since @Sukrityshrivastava did not continue to work on this, I would like to take this issue over. I am on it.

subkrish pushed a commit to subkrish/checkstyle that referenced this issue Apr 4, 2017

subkrish pushed a commit to subkrish/checkstyle that referenced this issue Apr 4, 2017

subkrish pushed a commit to subkrish/checkstyle that referenced this issue Apr 4, 2017

subkrish pushed a commit to subkrish/checkstyle that referenced this issue Apr 9, 2017

subkrish pushed a commit to subkrish/checkstyle that referenced this issue Apr 11, 2017

rnveach added a commit that referenced this issue Apr 12, 2017

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Apr 12, 2017

Member

Fix is merged

Member

rnveach commented Apr 12, 2017

Fix is merged

@rnveach rnveach closed this Apr 12, 2017

@rnveach rnveach added this to the 7.7 milestone Apr 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment