New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThreadLocal usage in single threaded checkstyle #2992

Closed
romani opened this Issue Mar 1, 2016 · 0 comments

Comments

Projects
None yet
2 participants
@romani
Member

romani commented Mar 1, 2016

Checkstyle is not multi-threaded by design right now. We will make it multi-threaded.

public class FileContentsHolder
    extends AbstractCheck {
    /** The current file contents. */
    private static final ThreadLocal<FileContents> FILE_CONTENTS = new ThreadLocal<>();

It was there from the beginning.
https://github.com/checkstyle/checkstyle/blame/262209477f39964a63103613f3e2c985da083371/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/FileContentsHolder.java
It is a mistake. We will fix this.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@romani romani added the approved label Mar 1, 2016

@romani romani assigned Vladlis and unassigned Vladlis Nov 23, 2016

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Nov 27, 2016

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Nov 27, 2016

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Nov 28, 2016

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Nov 28, 2016

romani added a commit that referenced this issue Nov 28, 2016

@romani romani added the bug label Nov 28, 2016

@romani romani added this to the 7.4 milestone Nov 28, 2016

@romani romani added miscellaneous and removed bug labels Nov 28, 2016

@romani romani closed this Nov 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment