fix TokenTypes compatibility problems between 6.15 and 6.16 #2997

Closed
romani opened this Issue Mar 2, 2016 · 3 comments

Projects

None yet

2 participants

@romani
Member
romani commented Mar 2, 2016

Commit 23e6eba

damaged compatibility between 6.16 and all previous releases.
checkstyle-6.15-all.jar:/com/puppycrawl/tools/checkstyle/grammars/GeneratedJavaTokenTypes.txt
checkstyle-6.16-all.jar:/com/puppycrawl/tools/checkstyle/grammars/GeneratedJavaTokenTypes.txt

screenshot-damage-compatibility-6 15-6 16

@romani
Member
romani commented Mar 2, 2016

We need to find way to prevent this to happen in Future by CI.

@sabaka
Contributor
sabaka commented Mar 2, 2016

And we should add additional comments to grammar with warning, I think. We have something like "put new tokens only in the end", but nothing about deletion.

@romani
Member
romani commented Mar 3, 2016

Nobody read comments.... UTs should teach future contributor and control us.

@romani romani added bug and removed breaking compatibility labels Mar 3, 2016
@romani romani added this to the 6.16.1 milestone Mar 3, 2016
@romani romani closed this Mar 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment