/checkstyle

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TokenTypes compatibility problems between 6.15 and 6.16 #2997

Closed
romani opened this Issue Mar 2, 2016 · 3 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  6.16.1
2 participants
@romani @sabaka
@romani
Member

romani commented Mar 2, 2016

Commit 23e6eba

damaged compatibility between 6.16 and all previous releases.
checkstyle-6.15-all.jar:/com/puppycrawl/tools/checkstyle/grammars/GeneratedJavaTokenTypes.txt
checkstyle-6.16-all.jar:/com/puppycrawl/tools/checkstyle/grammars/GeneratedJavaTokenTypes.txt

screenshot-damage-compatibility-6 15-6 16

@romani romani added approved breaking compatibility labels Mar 2, 2016

@romani romani referenced this issue Mar 2, 2016

Merged

Issue #2973: removed unused VOCAB from java.g #2983

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Mar 2, 2016

Member

We need to find way to prevent this to happen in Future by CI.
Member

romani commented Mar 2, 2016

We need to find way to prevent this to happen in Future by CI.

romani added a commit that referenced this issue Mar 2, 2016

@rnveach @romani
Issue #2997: added test to verify TokenType numbers
Loading status checks…
9ffb1ed
@sabaka

This comment has been minimized.

Show comment
Hide comment
@sabaka

sabaka Mar 2, 2016

Contributor

And we should add additional comments to grammar with warning, I think. We have something like "put new tokens only in the end", but nothing about deletion.
Contributor

sabaka commented Mar 2, 2016

And we should add additional comments to grammar with warning, I think. We have something like "put new tokens only in the end", but nothing about deletion.
@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Mar 3, 2016

Member

Nobody read comments.... UTs should teach future contributor and control us.
Member

romani commented Mar 3, 2016

Nobody read comments.... UTs should teach future contributor and control us.

@romani romani added bug and removed breaking compatibility labels Mar 3, 2016

@romani romani added this to the 6.16.1 milestone Mar 3, 2016

@romani romani closed this Mar 3, 2016

@Vladlis Vladlis referenced this issue Mar 18, 2016

Closed

exception in StaticMethodCandidate and EnumValueNameCheck on Checkstyle sources #429

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment