Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TokenTypes compatibility problems between 6.15 and 6.16 #2997

Closed
romani opened this issue Mar 2, 2016 · 3 comments
Closed

fix TokenTypes compatibility problems between 6.15 and 6.16 #2997

romani opened this issue Mar 2, 2016 · 3 comments
Labels
Milestone

Comments

@romani
Copy link
Member

@romani romani commented Mar 2, 2016

Commit 23e6eba

damaged compatibility between 6.16 and all previous releases.
checkstyle-6.15-all.jar:/com/puppycrawl/tools/checkstyle/grammars/GeneratedJavaTokenTypes.txt
checkstyle-6.16-all.jar:/com/puppycrawl/tools/checkstyle/grammars/GeneratedJavaTokenTypes.txt

screenshot-damage-compatibility-6 15-6 16

@romani
Copy link
Member Author

@romani romani commented Mar 2, 2016

We need to find way to prevent this to happen in Future by CI.

romani added a commit that referenced this issue Mar 2, 2016
@sabaka
Copy link
Contributor

@sabaka sabaka commented Mar 2, 2016

And we should add additional comments to grammar with warning, I think. We have something like "put new tokens only in the end", but nothing about deletion.

@romani
Copy link
Member Author

@romani romani commented Mar 3, 2016

Nobody read comments.... UTs should teach future contributor and control us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.