use new checks and new properties from sevntu.checkstyle project #3064

Closed
romani opened this Issue Mar 25, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Jan 6, 2017

Member

@romani We are already using all sevntu checks via travis:

# Ensure that all Sevntu check are kused

Are there any new properties we are missing?

Member

rnveach commented Jan 6, 2017

@romani We are already using all sevntu checks via travis:

# Ensure that all Sevntu check are kused

Are there any new properties we are missing?

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jan 6, 2017

Member

Old comment need to be removed https://github.com/checkstyle/checkstyle/blob/master/config/checkstyle_sevntu_checks.xml#L98 .

AvoidModifiersForTypes already use 3 options that were new in that release, it is enough.

Member

romani commented Jan 6, 2017

Old comment need to be removed https://github.com/checkstyle/checkstyle/blob/master/config/checkstyle_sevntu_checks.xml#L98 .

AvoidModifiersForTypes already use 3 options that were new in that release, it is enough.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jan 6, 2017

Member

Fix is merged

Member

romani commented Jan 6, 2017

Fix is merged

@romani romani closed this Jan 6, 2017

@rnveach rnveach self-assigned this Jan 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment