Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Indentation: remove requirement right curlies to be first on line #3116
When PR is merged, I will point to all marks here and my thoughts on them.
places where we use ioffset (3 instances)
Violation is for 2nd brace. Ideally it should be at column 12 on the next line.
Violation is for brace. Ideally it should be at column 8 on the next line.
Same as (2).
All 3 are pretty much the same.
The violations right now are basically saying this is what must be done. There is no way around it, as moving the brace backwards will instead report the node that starts the line. I don't consider the violations to be wrong but they definitely violate that rule.
If we truly don't want to force users to break lines, we must remove these and similar violations from being reported. We would have to pass over reporting any node that doesn't start a line.
If we want the violations to remain, there is no way to remove