Java 8 Grammar: annotations on varargs parameters

[rnveach]

Taken from PR #3230 when working on Issue #3033 from a run on OpenJDK 8/9.

$ cat TestClass.java
import java.lang.annotation.ElementType;
import java.lang.annotation.Target;

public class TestClass {
    public void m5(@Nullable String @Nullable ... vararg) {}
}

@Target(ElementType.TYPE_USE)
@interface Nullable {
}

$ cat TestConfig.xml
<?xml version="1.0"?>
<!DOCTYPE module PUBLIC
          "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
          "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">

<module name="Checker">
    <property name="charset" value="UTF-8"/>

    <module name="TreeWalker">
    </module>
</module>

$ java -jar checkstyle-6.19-all.jar -c TestConfig.xml TestClass.java
Starting audit...
TestClass.java:5:47: unexpected token: ...
Audit done.

Input is compilable with java 8 javac.

[romani]

Input is compilable with java 8 javac.

next time please prove this in console output.

[romani]

such syntax is now appeared at guava.

I am raising priority.

[strkkk]

@romani @rnveach
I couldn't reproduce this in 8.20 version, probably it was fixed.

$ cat TestClass.java
import java.lang.annotation.ElementType;
import java.lang.annotation.Target;

public class TestClass {
    public void m5(@Nullable String @Nullable ... vararg) {}
}

@Target(ElementType.TYPE_USE)
@interface Nullable {
}

$ cat conf.xml
<?xml version="1.0"?>
<!DOCTYPE module PUBLIC
          "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
          "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">

<module name="Checker">
    <property name="charset" value="UTF-8"/>

    <module name="TreeWalker">
    </module>
</module>

$ java -jar checkstyle-8.20-all.jar -c conf.xml TestClass.java
Starting audit...
Audit done.

[rnveach]

@strkkk Some things in Checkstyle have changed since my initial report. TreeWalker does nothing if it doesn't have any children module. If you add a module or print the tree, you will see the exception still occurs.

com.puppycrawl.tools.checkstyle.api.CheckstyleException: IllegalStateException occurred while parsing file TestClass.java.
    at com.puppycrawl.tools.checkstyle.JavaParser.parse(JavaParser.java:105)
    at com.puppycrawl.tools.checkstyle.JavaParser.parseFileText(JavaParser.java:121)
    at com.puppycrawl.tools.checkstyle.JavaParser.parseFile(JavaParser.java:140)
    at com.puppycrawl.tools.checkstyle.AstTreeStringPrinter.printJavaAndJavadocTree(AstTreeStringPrinter.java:76)
    at com.puppycrawl.tools.checkstyle.Main.runCli(Main.java:289)
    at com.puppycrawl.tools.checkstyle.Main.execute(Main.java:180)
    at com.puppycrawl.tools.checkstyle.Main.main(Main.java:119)
Caused by: java.lang.IllegalStateException: TestClass.java:5:47: unexpected token: ...
    at com.puppycrawl.tools.checkstyle.JavaParser$1.reportError(JavaParser.java:93)
    at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.typeDefinition(GeneratedJavaRecognizer.java:411)
    at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.compilationUnit(GeneratedJavaRecognizer.java:202)
    at com.puppycrawl.tools.checkstyle.JavaParser.parse(JavaParser.java:99)
    ... 6 more
Caused by: TestClass.java:5:47: unexpected token: ...
    at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.annotation(GeneratedJavaRecognizer.java:1822)
    at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.annotations(GeneratedJavaRecognizer.java:226)
    at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.classTypeSpec(GeneratedJavaRecognizer.java:826)
    at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.typeSpec(GeneratedJavaRecognizer.java:780)
    at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.variableLengthParameterDeclaration(GeneratedJavaRecognizer.java:4860)
    at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.parameterDeclarationList(GeneratedJavaRecognizer.java:3844)
    at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.field(GeneratedJavaRecognizer.java:3302)
    at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.classBlock(GeneratedJavaRecognizer.java:2542)
    at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.classDefinition(GeneratedJavaRecognizer.java:634)
    at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.typeDefinitionInternal(GeneratedJavaRecognizer.java:556)
    at com.puppycrawl.tools.checkstyle.grammar.GeneratedJavaRecognizer.typeDefinition(GeneratedJavaRecognizer.java:389)
    ... 8 more

[sanyarnd]

Issue is still present in 8.23

[frankbenoit]

Issue is still present in 8.24

[romani]

fix is merged

[romani]

@esilkensen , please contact me in gitter chat or send me email.