Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Modules and XDocs: changed setter methods to recieve similar types with field type for easier xdoc validation #3255
Taken from Issue #3212
To create a JUnit for module's default types we need to know the type we are dealing with to display it correctly. Unfortunately, We use String in the setter for everything, from regular expressions, file locations, to custom enumerations.
This issue is specifically to change all
Yes it is reasonable.
Check are our implementations, they should be able to be created as java beans and used with fully typed parameters. String was used only to simplify customization from XML (strings only format). We already have bunch of converters, we control code that read that XML so we can use custom converters. Users will still use string values in config file to do configuration.
No breaking compatibility is expected.
referenced this issue
Nov 4, 2016
added a commit
Nov 9, 2016
I did a merge of first big update for RegExp.
we do not really need to store
@romani To confirm, some checks use format to display violation. We will keep fields for those instances or replace them with
Also to confirm, this will involve renaming
I do not follow you, can you send me a link to code. If that is not user property - it is ok to rename to keep name correct.