CommitValidationTest.testCommitMessageHasSingleLine to support github default format #3266

Closed
romani opened this Issue Jun 10, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@romani
Member

romani commented Jun 10, 2016

Example: https://travis-ci.org/checkstyle/checkstyle/jobs/136760315#L794

Reason: I did merge from web UI. Such format is used by default in github.

I think we need to extend validation to allow such format. I more and more use web ui merge to speed up process.

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Jun 10, 2016

Member

It looks like commit message is stored as "commit\n\n", if u can confirm.
We should rewrite the test to also be more specific about reason for failure so its easier to track down issues.

I will work on this.

Member

rnveach commented Jun 10, 2016

It looks like commit message is stored as "commit\n\n", if u can confirm.
We should rewrite the test to also be more specific about reason for failure so its easier to track down issues.

I will work on this.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jun 11, 2016

Member

I can confirm that i did just a merge from web ui. Sing of web ui usage is extra reference of PR number at the end of message - Issue #3142: Add proper support for generics in VisibilityModifierCheck (#3247)

Member

romani commented Jun 11, 2016

I can confirm that i did just a merge from web ui. Sing of web ui usage is extra reference of PR number at the end of message - Issue #3142: Add proper support for generics in VisibilityModifierCheck (#3247)

@romani romani added the approved label Jun 12, 2016

romani added a commit that referenced this issue Jun 12, 2016

@romani romani added this to the 7.0 milestone Jun 12, 2016

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jun 12, 2016

Member

fix is merged.

Member

romani commented Jun 12, 2016

fix is merged.

@romani romani closed this Jun 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment