New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RedundantModifier : missed violations at interface and abstract class methods signatures with final parameters #3322

Closed
romani opened this Issue Jun 28, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@romani
Member

romani commented Jun 28, 2016

/var/tmp $ cat TestClass.java 
public interface IWhatever {
    void doSomething(final String param);
}
abstract class Whatever {
    public abstract void doSomething(final String param);
}

/var/tmp $ cat my_check.xml 
<?xml version="1.0"?>
<!DOCTYPE module PUBLIC
          "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
          "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
<module name = "Checker">
    <module name="TreeWalker">
        <module name="RedundantModifier"/>
    </module>
</module>

/var/tmp $ java -jar checkstyle-7.0-all.jar -c my_check.xml TestClass.java 
Starting audit...
Audit done.

Expected: violation at 2 and 5.

@romani romani changed the title from RedundantModifier : missed violations at interface and abstract class methods signatures to RedundantModifier : missed violations at interface and abstract class methods signatures with final parameters Jun 28, 2016

rnveach added a commit to rnveach/checkstyle that referenced this issue Aug 1, 2016

romani added a commit that referenced this issue Aug 4, 2016

@romani romani added this to the 7.2 milestone Aug 4, 2016

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Aug 4, 2016

Member

fix is merged.

Member

romani commented Aug 4, 2016

fix is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment