New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Google style coverage to state of 12 July 2016 #3381

Closed
romani opened this Issue Jul 31, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@romani
Member

romani commented Jul 31, 2016

@agcuda

This comment has been minimized.

Show comment
Hide comment
@agcuda

agcuda Aug 31, 2016

Contributor

It seems to me that the only changes that affect checkstyle are:

  • 3.3.3: Import order (already addressed by #941)
  • 4.5: method reference (::) behaves like dot separator etc
  • 4.8.7: added "default" modifier
  • 5.2.6: parameter names can be one-character long in non-public methods

The last three items are pretty trivial to implement, and I could create a pull request for each of them. Would you like me to create also three new issues or pull requests should simply reference this issue?

Contributor

agcuda commented Aug 31, 2016

It seems to me that the only changes that affect checkstyle are:

  • 3.3.3: Import order (already addressed by #941)
  • 4.5: method reference (::) behaves like dot separator etc
  • 4.8.7: added "default" modifier
  • 5.2.6: parameter names can be one-character long in non-public methods

The last three items are pretty trivial to implement, and I could create a pull request for each of them. Would you like me to create also three new issues or pull requests should simply reference this issue?

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Aug 31, 2016

Member

Please reference one issue, please do not forget to update xdoc file that show coverage of rules

Member

romani commented Aug 31, 2016

Please reference one issue, please do not forget to update xdoc file that show coverage of rules

agcuda added a commit to agcuda/checkstyle that referenced this issue Sep 1, 2016

agcuda added a commit to agcuda/checkstyle that referenced this issue Sep 1, 2016

agcuda added a commit to agcuda/checkstyle that referenced this issue Sep 1, 2016

agcuda added a commit to agcuda/checkstyle that referenced this issue Sep 1, 2016

@agcuda

This comment has been minimized.

Show comment
Hide comment
@agcuda

agcuda Sep 1, 2016

Contributor

Ok. I have created three different pull requests since they all impact the code. If/when they are approved I will also update the coverage doc, it that's ok for you.

EDIT: I have noticed now that you don't allow multiple push requests to reference the same issue. I have built a single push request that contains everything. Sorry for the mess.

Contributor

agcuda commented Sep 1, 2016

Ok. I have created three different pull requests since they all impact the code. If/when they are approved I will also update the coverage doc, it that's ok for you.

EDIT: I have noticed now that you don't allow multiple push requests to reference the same issue. I have built a single push request that contains everything. Sorry for the mess.

agcuda added a commit to agcuda/checkstyle that referenced this issue Sep 1, 2016

agcuda added a commit to agcuda/checkstyle that referenced this issue Sep 1, 2016

agcuda added a commit to agcuda/checkstyle that referenced this issue Sep 2, 2016

agcuda added a commit to agcuda/checkstyle that referenced this issue Nov 8, 2016

agcuda added a commit to agcuda/checkstyle that referenced this issue Nov 9, 2016

agcuda added a commit to agcuda/checkstyle that referenced this issue Nov 10, 2016

agcuda added a commit to agcuda/checkstyle that referenced this issue Nov 10, 2016

agcuda added a commit to agcuda/checkstyle that referenced this issue Nov 10, 2016

agcuda added a commit to agcuda/checkstyle that referenced this issue Nov 11, 2016

agcuda added a commit to agcuda/checkstyle that referenced this issue Nov 11, 2016

romani added a commit that referenced this issue Nov 12, 2016

@romani romani added this to the 7.3 milestone Nov 12, 2016

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Nov 12, 2016

Member

fix is merged.

Member

romani commented Nov 12, 2016

fix is merged.

@romani romani closed this Nov 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment