New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: remove from API all guava code #3455

Closed
romani opened this Issue Sep 20, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@romani
Member

romani commented Sep 20, 2016

Checkstyle 8 task.

file config/import-control.xml

<allow class="com.google.common.io.Closeables" local-only="true"/>
<allow class="com.google.common.collect.ImmutableCollection" local-only="true"/>
<allow class="com.google.common.collect.ImmutableMap" local-only="true"/>

API should be clear from any non standard classes.

Since this change is being done in API code, this will break backward compatibility with any existing code that uses it if it is not re-compiled. When upgrading, to mitigate this issue, all custom JARs must be recompiled against new checkstyle code.

Example of failure:
https://app.wercker.com/checkstyle/checkstyle/runs/build/5a27437a9fe1e0000127e823?step=5a2743a0540e1a00018beb4f

java.lang.Error: Error was thrown while processing /pipeline/source/src/test/java/com/puppycrawl/tools/checkstyle/AbstractPathTestSupport.java
Caused by: java.lang.NoSuchMethodError: com.puppycrawl.tools.checkstyle.api.FileContents.getBlockComments()Lcom/google/common/collect/ImmutableMap;

The method still does exist, but the signature was changed. So technically there is nothing wrong with code, it just needs to be recompiled to correct the signature.

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Nov 3, 2016

Member

@romani I think this can have the checkstyle 8 label.

Member

rnveach commented Nov 3, 2016

@romani I think this can have the checkstyle 8 label.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Dec 31, 2017

Member

fix is merged

Member

romani commented Dec 31, 2017

fix is merged

@romani romani closed this Dec 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment