New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReturnCount: enforce max=1 over checkstyle code #3496

Closed
romani opened this Issue Oct 4, 2016 · 13 comments

Comments

Projects
5 participants
@romani
Member

romani commented Oct 4, 2016

http://checkstyle.sourceforge.net/config_coding.html#ReturnCount

in checkstyle code we use default value - 2.
https://github.com/search?q=path%3Aconfig+filename%3Acheckstyle_checks.xml+repo%3Acheckstyle%2Fcheckstyle+ReturnCount

we need to make it "1".
Previously I failed to do this as there was too much other problems and I decided to postpone it.
Now I fed up to force people at code review to do methods with one return.

We have additional Check - https://github.com/sevntu-checkstyle/sevntu.checkstyle/blob/master/sevntu-checks/src/main/java/com/github/sevntu/checkstyle/checks/coding/ReturnCountExtendedCheck.java
that is used over our code, it has more options, so could be used to do refactoring step by steps.
its config: https://github.com/checkstyle/checkstyle/blob/master/config/checkstyle_sevntu_checks.xml#L191

@romani romani added the approved label Oct 4, 2016

@MEZk

This comment has been minimized.

Show comment
Hide comment
@MEZk

MEZk Oct 18, 2016

Contributor

In addition, we should remove OnlyOneReturn from excludes of PMD.

Contributor

MEZk commented Oct 18, 2016

In addition, we should remove OnlyOneReturn from excludes of PMD.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Oct 18, 2016

Member

Refactoring should be done with caution, as single return point is not always reasonable. In sevntu-checkstyle project we have special Check that relax strict rules for somw cases.

Member

romani commented Oct 18, 2016

Refactoring should be done with caution, as single return point is not always reasonable. In sevntu-checkstyle project we have special Check that relax strict rules for somw cases.

@rnveach rnveach added the easy label Mar 2, 2017

@romani romani added hard and removed easy labels Apr 3, 2017

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Apr 20, 2017

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Apr 20, 2017

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Apr 20, 2017

Issue #3496: Enforce ReturnCount max=1 in com.puppycrawl.tools.checks…
…tyle.checks and com.puppycrawl.tools.checkstyle
@Vladlis

This comment has been minimized.

Show comment
Hide comment
@Vladlis

Vladlis Apr 20, 2017

Member

I am on it

Member

Vladlis commented Apr 20, 2017

I am on it

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Apr 20, 2017

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Apr 20, 2017

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Apr 20, 2017

Issue #3496: Enforce ReturnCount max=1 in com.puppycrawl.tools.checks…
…tyle.checks and com.puppycrawl.tools.checkstyle

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Apr 20, 2017

Issue #3496: Enforce ReturnCount max=1 in com.puppycrawl.tools.checks…
…tyle.internal, com.puppycrawl.tools.checkstyle.utils

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Apr 20, 2017

Issue #3496: Enforce ReturnCount max=1 in com.puppycrawl.tools.checks…
…tyle.checks and com.puppycrawl.tools.checkstyle

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Apr 20, 2017

Issue #3496: Enforce ReturnCount max=1 in com.puppycrawl.tools.checks…
…tyle.checks and com.puppycrawl.tools.checkstyle

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Apr 21, 2017

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Apr 21, 2017

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Apr 21, 2017

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Apr 21, 2017

Issue #3496: Enforce ReturnCount max=1 in com.puppycrawl.tools.checks…
…tyle.checks and com.puppycrawl.tools.checkstyle

rnveach added a commit that referenced this issue Apr 22, 2017

Issue #3496: Enforce ReturnCount max=1 in com.puppycrawl.tools.checks…
…tyle.checks and com.puppycrawl.tools.checkstyle

@rnveach rnveach added this to the 7.7 milestone Apr 22, 2017

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Apr 22, 2017

Issue #3496: Enforce ReturnCount max=1 in com.puppycrawl.tools.checks…
…tyle.internal, com.puppycrawl.tools.checkstyle.utils

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Apr 22, 2017

Issue #3496: Enforce ReturnCount max=1 in com.puppycrawl.tools.checks…
…tyle.gui, com.puppycrawl.tools.checkstyle.whitespace, com.puppycrawl.tools.checkstyle.doclets

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Apr 22, 2017

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Apr 22, 2017

Issue #3496: Enforce ReturnCount max=1 in com.puppycrawl.tools.checks…
…tyle.internal, com.puppycrawl.tools.checkstyle.utils

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Apr 22, 2017

Issue #3496: Enforce ReturnCount max=1 in com.puppycrawl.tools.checks…
…tyle.gui, com.puppycrawl.tools.checkstyle.whitespace, com.puppycrawl.tools.checkstyle.doclets

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Apr 22, 2017

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Apr 23, 2017

Issue #3496: Enforce ReturnCount max=1 in com.puppycrawl.tools.checks…
…tyle.gui, com.puppycrawl.tools.checkstyle.whitespace, com.puppycrawl.tools.checkstyle.doclets

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Apr 23, 2017

Issue #3496: Enforce ReturnCount max=1 in com.puppycrawl.tools.checks…
…tyle.internal, com.puppycrawl.tools.checkstyle.utils

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Apr 23, 2017

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Apr 23, 2017

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Apr 23, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

Issue #3496: Enforce ReturnCount max=1 in com.puppycrawl.tools.checks…
…tyle.checks.annotation, com.puppycrawl.tools.checkstyle.ant

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

Issue #3496: Enforce ReturnCount max=1 in com.puppycrawl.tools.checks…
…tyle.gui, com.puppycrawl.tools.checkstyle.whitespace, com.puppycrawl.tools.checkstyle.doclets

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

Issue #3496: Enforce ReturnCount max=1 in com.puppycrawl.tools.checks…
…tyle.internal, com.puppycrawl.tools.checkstyle.utils

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

Issue #3496: Enforce ReturnCount max=1 in com.puppycrawl.tools.checks…
…tyle.checks.annotation, com.puppycrawl.tools.checkstyle.ant

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach May 12, 2017

Member

It looks like only 2 packages are left, coding and indentation.

<!-- Until https://github.com/checkstyle/checkstyle/issues/3496 -->

Member

rnveach commented May 12, 2017

It looks like only 2 packages are left, coding and indentation.

<!-- Until https://github.com/checkstyle/checkstyle/issues/3496 -->

@Vladlis

This comment has been minimized.

Show comment
Hide comment
@Vladlis

Vladlis May 12, 2017

Member

@rnveach
Yes, sorry, I forgot to comment, that I've stopped working on this issue as it will be resolved during GSoC.

Also PMD's OnlyOneReturn rule gives a lot more violations, so investigation is required on why our Check does not find these violations too.

Member

Vladlis commented May 12, 2017

@rnveach
Yes, sorry, I forgot to comment, that I've stopped working on this issue as it will be resolved during GSoC.

Also PMD's OnlyOneReturn rule gives a lot more violations, so investigation is required on why our Check does not find these violations too.

@romani romani added the GSoC2017 label May 12, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani May 12, 2017

Member

issue is assigned to GSoC project, label is provided.

Member

romani commented May 12, 2017

issue is assigned to GSoC project, label is provided.

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach May 12, 2017

Member

Also PMD's OnlyOneReturn rule gives a lot more violations

From another suppression,

<suppress checks="ReturnCount" files="(ClassResolver|ConfigurationLoader|IndentationCheckTest)\.java"/>

and from check's default suppression of equals methods:
private Pattern format = Pattern.compile("^equals$");

Member

rnveach commented May 12, 2017

Also PMD's OnlyOneReturn rule gives a lot more violations

From another suppression,

<suppress checks="ReturnCount" files="(ClassResolver|ConfigurationLoader|IndentationCheckTest)\.java"/>

and from check's default suppression of equals methods:
private Pattern format = Pattern.compile("^equals$");

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 27, 2017

Member

fixed in scope of #4723 during resolving violations of MultipleReturnPointsPerMethod inspection

Member

romani commented Jul 27, 2017

fixed in scope of #4723 during resolving violations of MultipleReturnPointsPerMethod inspection

@romani romani closed this Jul 27, 2017

@romani romani moved this from To Do to Done in Practice What You Preach Jul 27, 2017

@Vladlis

This comment has been minimized.

Show comment
Hide comment
@Vladlis

Vladlis Jul 27, 2017

Member

@romani
There is a suppression left: https://github.com/checkstyle/checkstyle/blob/master/config/suppressions.xml#L96, without it ReturnCount check gives:

     [echo] Checkstyle started (checkstyle_checks.xml): 27/07/2017 06:01:28 PM
[checkstyle] Running Checkstyle 8.2-SNAPSHOT on 941 files
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/AbstractSuperCheck.java:149:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/EqualsAvoidNullCheck.java:363:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/EqualsAvoidNullCheck.java:607:9: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/ExplicitInitializationCheck.java:193:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/FallThroughCheck.java:374:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/HiddenFieldCheck.java:404:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/HiddenFieldCheck.java:654:9: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalInstantiationCheck.java:328:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/InnerAssignmentCheck.java:171:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/InnerAssignmentCheck.java:196:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/MultipleStringLiteralsCheck.java:153:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/SimplifyBooleanReturnCheck.java:110:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/UnnecessaryParenthesesCheck.java:321:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/ArrayInitHandler.java:44:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/ArrayInitHandler.java:119:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/IfHandler.java:44:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/IfHandler.java:52:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/IndentLevel.java:117:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/LambdaHandler.java:48:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/NewHandler.java:56:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/SlistHandler.java:70:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/TryHandler.java:43:5: Return count is 2 (max allowed is 1). [ReturnCount]
Member

Vladlis commented Jul 27, 2017

@romani
There is a suppression left: https://github.com/checkstyle/checkstyle/blob/master/config/suppressions.xml#L96, without it ReturnCount check gives:

     [echo] Checkstyle started (checkstyle_checks.xml): 27/07/2017 06:01:28 PM
[checkstyle] Running Checkstyle 8.2-SNAPSHOT on 941 files
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/AbstractSuperCheck.java:149:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/EqualsAvoidNullCheck.java:363:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/EqualsAvoidNullCheck.java:607:9: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/ExplicitInitializationCheck.java:193:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/FallThroughCheck.java:374:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/HiddenFieldCheck.java:404:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/HiddenFieldCheck.java:654:9: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalInstantiationCheck.java:328:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/InnerAssignmentCheck.java:171:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/InnerAssignmentCheck.java:196:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/MultipleStringLiteralsCheck.java:153:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/SimplifyBooleanReturnCheck.java:110:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/UnnecessaryParenthesesCheck.java:321:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/ArrayInitHandler.java:44:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/ArrayInitHandler.java:119:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/IfHandler.java:44:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/IfHandler.java:52:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/IndentLevel.java:117:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/LambdaHandler.java:48:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/NewHandler.java:56:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/SlistHandler.java:70:5: Return count is 2 (max allowed is 1). [ReturnCount]
[checkstyle] [ERROR] /home/vlad/workspace/opensource/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/TryHandler.java:43:5: Return count is 2 (max allowed is 1). [ReturnCount]

@Vladlis Vladlis reopened this Jul 27, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 27, 2017

Member

I reverted my commit.
We will investigate it later on. Strange I can not reproduce this on my local.

Member

romani commented Jul 27, 2017

I reverted my commit.
We will investigate it later on. Strange I can not reproduce this on my local.

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Jul 27, 2017

Member

Strange I can not reproduce this on my local.

@romani This is another case of seeing different results with different execution order like #3340.

We have 2 modules defined exactly the same, except one is given a special ID returnCountMaxOne and the other isn't.
If the one with the ID is run first, it's violation is added to the queue of messages. If the one without the ID is run second, it sees the one with the ID as a duplicate violation and so it doesn't add the 2nd violation to the list of messages.
When we got down to the suppressions, https://github.com/checkstyle/checkstyle/blob/master/config/suppressions.xml#L96 was matching up with our 1 violation, hence it was suppressed.
If the one without the ID was run first, you would have seen the violation like one travis run did.

Issue #4607 should fix this problem.

Member

rnveach commented Jul 27, 2017

Strange I can not reproduce this on my local.

@romani This is another case of seeing different results with different execution order like #3340.

We have 2 modules defined exactly the same, except one is given a special ID returnCountMaxOne and the other isn't.
If the one with the ID is run first, it's violation is added to the queue of messages. If the one without the ID is run second, it sees the one with the ID as a duplicate violation and so it doesn't add the 2nd violation to the list of messages.
When we got down to the suppressions, https://github.com/checkstyle/checkstyle/blob/master/config/suppressions.xml#L96 was matching up with our 1 violation, hence it was suppressed.
If the one without the ID was run first, you would have seen the violation like one travis run did.

Issue #4607 should fix this problem.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Aug 22, 2017

Member

last PR is send to verification - #4982 .
As it merge, issue could be closed.

Member

romani commented Aug 22, 2017

last PR is send to verification - #4982 .
As it merge, issue could be closed.

@romani romani moved this from To Do to In Progress in Practice What You Preach Aug 22, 2017

romani added a commit that referenced this issue Aug 22, 2017

romani added a commit that referenced this issue Aug 22, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Aug 22, 2017

Member

final is merged.

Member

romani commented Aug 22, 2017

final is merged.

@romani romani closed this Aug 22, 2017

@romani romani moved this from In Progress to Done in Practice What You Preach Aug 22, 2017

ArneLimburg pushed a commit to ArneLimburg/checkstyle that referenced this issue Aug 23, 2017

ArneLimburg pushed a commit to ArneLimburg/checkstyle that referenced this issue Aug 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment