New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DetailAST log away from AbstractViolationReporter #3574

Closed
rnveach opened this Issue Nov 23, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@rnveach
Member

rnveach commented Nov 23, 2016

/**
* Helper method to log a LocalizedMessage.
*
* @param ast a node to get line id column numbers associated
* with the message
* @param key key to locale message format
* @param args arguments to format
*/
protected final void log(DetailAST ast, String key, Object... args) {
log(ast.getLineNo(), ast.getColumnNo(), key, args);
}

This method is purely for Java and antlr checks to use, but it is located in a base abstract class used by filters and other things possibly never doing anything antlr related.
It should be moved to a more logical place like AbstractCheck.

@rnveach rnveach added the checkstyle8 label Nov 23, 2016

@romani romani added the approved label Nov 23, 2016

@sagar-shah94

This comment has been minimized.

Show comment
Hide comment
@sagar-shah94

sagar-shah94 Mar 6, 2017

Contributor

I am on it

Contributor

sagar-shah94 commented Mar 6, 2017

I am on it

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Mar 6, 2017

Member

@sagar-shah94 You cannot work on this issue. It is labeled with Checkstyle 8 and we are still on version 7.
It is a backward-breaking change and must wait for the new version.

Member

rnveach commented Mar 6, 2017

@sagar-shah94 You cannot work on this issue. It is labeled with Checkstyle 8 and we are still on version 7.
It is a backward-breaking change and must wait for the new version.

rnveach added a commit to rnveach/checkstyle that referenced this issue Jun 30, 2017

rnveach added a commit to rnveach/checkstyle that referenced this issue Jul 1, 2017

rnveach added a commit to rnveach/checkstyle that referenced this issue Jul 2, 2017

rnveach added a commit to rnveach/checkstyle that referenced this issue Jul 2, 2017

romani added a commit that referenced this issue Jul 6, 2017

@romani romani added this to the 8.1 milestone Jul 6, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 6, 2017

Member

fix is merged

Member

romani commented Jul 6, 2017

fix is merged

@romani romani closed this Jul 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment