New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo files should not have execute permissions #3600

Closed
romani opened this Issue Nov 29, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@romani
Member

romani commented Nov 29, 2016

$ ll
total 1488
drwxrwxr-x 2 rivanov rivanov   4096 Nov 23 13:43 ./
drwxrwxr-x 7 rivanov rivanov   4096 Jun 24 10:58 ../
-rw-rw-r-- 1 rivanov rivanov  13370 May 20  2016 anttask.xml.vm
...
-rw-rw-r-- 1 rivanov rivanov  56984 Nov 14 13:05 config_imports.xml
-rw-rw-r-- 1 rivanov rivanov  76904 Nov 14 13:05 config_javadoc.xml
-rw-rw-r-- 1 rivanov rivanov  34304 Jun 10 06:33 config_metrics.xml
-rwxrwxr-x 1 rivanov rivanov  71591 Nov 14 13:05 config_misc.xml*
...

attention to last line "rwx", "x" flag on files is not required , except for "*.sh" files.
please find other files in repo, there should be more files like this.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@MaksimP

This comment has been minimized.

Show comment
Hide comment
@MaksimP

MaksimP Dec 8, 2016

Contributor

little bash script
find ./src ./config -type f -perm 775 -print;

./src/main/java/com/puppycrawl/tools/checkstyle/api/DetailAST.java
./src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractJavadocCheck.java
./src/main/java/com/puppycrawl/tools/checkstyle/TreeWalker.java
./src/main/resources/com/puppycrawl/tools/checkstyle/grammars/javadoc/JavadocLexer.g4
./src/main/resources/com/puppycrawl/tools/checkstyle/grammars/javadoc/JavadocParser.g4
./src/xdocs/config_misc.xml

Contributor

MaksimP commented Dec 8, 2016

little bash script
find ./src ./config -type f -perm 775 -print;

./src/main/java/com/puppycrawl/tools/checkstyle/api/DetailAST.java
./src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractJavadocCheck.java
./src/main/java/com/puppycrawl/tools/checkstyle/TreeWalker.java
./src/main/resources/com/puppycrawl/tools/checkstyle/grammars/javadoc/JavadocLexer.g4
./src/main/resources/com/puppycrawl/tools/checkstyle/grammars/javadoc/JavadocParser.g4
./src/xdocs/config_misc.xml

@MaksimP

This comment has been minimized.

Show comment
Hide comment
@MaksimP

MaksimP Dec 9, 2016

Contributor

now after "git fetch" or "git clone" from ....checkstyle/checkstyle.git

./src/main/java/com/puppycrawl/tools/checkstyle/api/DetailAST.java
./src/main/java/com/puppycrawl/tools/checkstyle/api/TokenTypes.java
./src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractJavadocCheck.java
./src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/WhitespaceAfterCheck.java
./src/main/java/com/puppycrawl/tools/checkstyle/TreeWalker.java
./src/main/resources/com/puppycrawl/tools/checkstyle/grammars/javadoc/JavadocLexer.g4
./src/main/resources/com/puppycrawl/tools/checkstyle/grammars/javadoc/JavadocParser.g4
./src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/WhitespaceAfterCheckTest.java
./src/test/java/com/puppycrawl/tools/checkstyle/grammars/GeneratedJavaTokenTypesTest.java
./src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/InputDoWhile.java
./src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/InputWhitespaceAfter.java
./src/xdocs/config_misc.xml
./src/xdocs/config_whitespace.xml

Contributor

MaksimP commented Dec 9, 2016

now after "git fetch" or "git clone" from ....checkstyle/checkstyle.git

./src/main/java/com/puppycrawl/tools/checkstyle/api/DetailAST.java
./src/main/java/com/puppycrawl/tools/checkstyle/api/TokenTypes.java
./src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractJavadocCheck.java
./src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/WhitespaceAfterCheck.java
./src/main/java/com/puppycrawl/tools/checkstyle/TreeWalker.java
./src/main/resources/com/puppycrawl/tools/checkstyle/grammars/javadoc/JavadocLexer.g4
./src/main/resources/com/puppycrawl/tools/checkstyle/grammars/javadoc/JavadocParser.g4
./src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/WhitespaceAfterCheckTest.java
./src/test/java/com/puppycrawl/tools/checkstyle/grammars/GeneratedJavaTokenTypesTest.java
./src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/InputDoWhile.java
./src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/InputWhitespaceAfter.java
./src/xdocs/config_misc.xml
./src/xdocs/config_whitespace.xml

MaksimP added a commit to MaksimP/checkstyle that referenced this issue Dec 9, 2016

MaksimP added a commit to MaksimP/checkstyle that referenced this issue Dec 9, 2016

romani added a commit that referenced this issue Dec 10, 2016

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Dec 10, 2016

Member

fix is merged.

$ find ./src ./config -type f -perm 775 -print;
return no result.

Member

romani commented Dec 10, 2016

fix is merged.

$ find ./src ./config -type f -perm 775 -print;
return no result.

@romani romani closed this Dec 10, 2016

@romani romani added this to the 7.4 milestone Dec 10, 2016

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Dec 10, 2016

Member

@romani We aren't adding this to travis to verify we don't break this in the future?
Notification of this in github review is not very noticeable. Even you couldn't find it when i first pointed it out.

Member

rnveach commented Dec 10, 2016

@romani We aren't adding this to travis to verify we don't break this in the future?
Notification of this in github review is not very noticeable. Even you couldn't find it when i first pointed it out.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Dec 10, 2016

Member

If that problem happen one more time, we will make validation in travis

Member

romani commented Dec 10, 2016

If that problem happen one more time, we will make validation in travis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment