New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new TeamCity violations #3616

Closed
rnveach opened this Issue Dec 6, 2016 · 12 comments

Comments

Projects
None yet
3 participants
@rnveach
Member

rnveach commented Dec 6, 2016

https://teamcity.jetbrains.com/viewLog.html?buildId=940313&tab=Inspection&buildTypeId=Checkstyle_IdeaInspectionsPullRequest

Number of inspection errors 1255 is 1255 more than the provided threshold 0
Number of inspection warnings 1126 is 1126 more than the provided threshold 0

I believe this is because of the new release of TC.
These violations must be fixed, or suppressed if needed, to continue development and using it as CI.

 Code maturity issues
Deprecated member is still used (9)
 Compiler issues
Unchecked warning (Errors) (3)
 Data flow issues
Scope of variable is too broad (Errors) (18)
 Declaration redundancy
Method returns the same value (1)
Redundant throws clause (Errors) (11)
Redundant throws declaration (Errors) (11)
 Dependency issues
Class with too many transitive dependents (Errors) (7)
 Encapsulation issues
'public' field (13)
 General
Annotator (2)
Redundant suppression (Errors) (12)
 Imports
Unused import (965)
 Java language level migration aids
Usages of API which isn't available at the configured language level (Errors) (1183)
 Javadoc issues
Declaration has problems in Javadoc references (53)
Unnecessary {@inheritDoc} Javadoc Comment (Errors) (1)
 Method metrics
Method with too many parameters (Errors) (2)
 Naming conventions
Instance method naming convention (1)
Package naming convention (30)
 Performance issues
Method may be 'static' (51)
 Probable bugs
Result of method call ignored (1)
Unused assignment (Errors) (6)
 Serialization issues
Non-serializable class with 'serialVersionUID' (Errors) (1)

@rnveach rnveach added the high demand label Dec 6, 2016

@romani romani added the approved label Dec 6, 2016

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Dec 6, 2016

Member

master validation is relaunched, not is failed by the same reason, to show other in PR that it is not their fault.

My proposal is to fix simple stuff, and more complicated groups to suppress (in config) for now to address them later on, without blocking the PR process.

Member

romani commented Dec 6, 2016

master validation is relaunched, not is failed by the same reason, to show other in PR that it is not their fault.

My proposal is to fix simple stuff, and more complicated groups to suppress (in config) for now to address them later on, without blocking the PR process.

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Dec 7, 2016

Member

Errors may not be valid. An issue has been filed.
https://teamcity-support.jetbrains.com/hc/en-us/requests/823672
https://youtrack.jetbrains.com/issue/TW-48065

A lot of ... indicates that project was not correctly imported

Member

rnveach commented Dec 7, 2016

Errors may not be valid. An issue has been filed.
https://teamcity-support.jetbrains.com/hc/en-us/requests/823672
https://youtrack.jetbrains.com/issue/TW-48065

A lot of ... indicates that project was not correctly imported

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Dec 7, 2016

Member

From support https://teamcity-support.jetbrains.com/hc/requests/818866 :

Vladislav Rassokhin­ (TeamCity)­
Dec 7, 18:25 MSK ­

Hi,­

Unfortunately I've to­ revert that upgrade ­to IDEA 2016.3 
due to­ problem with inspecti­ons. I'm sure you've alr­eady
 seen that. We wi­ll investigate furthe­r with IDEA team
 and ­then would again try ­to migrate to IDEA 20­16.3.

Vladislav Rassokhin­
Java developer (Team­City)
JetBrains­
Member

romani commented Dec 7, 2016

From support https://teamcity-support.jetbrains.com/hc/requests/818866 :

Vladislav Rassokhin­ (TeamCity)­
Dec 7, 18:25 MSK ­

Hi,­

Unfortunately I've to­ revert that upgrade ­to IDEA 2016.3 
due to­ problem with inspecti­ons. I'm sure you've alr­eady
 seen that. We wi­ll investigate furthe­r with IDEA team
 and ­then would again try ­to migrate to IDEA 20­16.3.

Vladislav Rassokhin­
Java developer (Team­City)
JetBrains­
@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Mar 27, 2017

Member

teamcity is upgraded to new IntelijIdea

in recent PR #4108 :

[00:38:20] : [Step 2/2] Starting up IntelliJ IDEA 2017.1.1 EAP (build IU-171.4011) ...done.

so we have to fix all that violations asap or suppress .... to unblock PRs .
Next build on master will fail for sure.

Member

romani commented Mar 27, 2017

teamcity is upgraded to new IntelijIdea

in recent PR #4108 :

[00:38:20] : [Step 2/2] Starting up IntelliJ IDEA 2017.1.1 EAP (build IU-171.4011) ...done.

so we have to fix all that violations asap or suppress .... to unblock PRs .
Next build on master will fail for sure.

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Mar 27, 2017

Member

Errors don't look valid again.
I re-posted issue to original issue tracker, https://youtrack.jetbrains.com/issue/TW-48065 .

Member

rnveach commented Mar 27, 2017

Errors don't look valid again.
I re-posted issue to original issue tracker, https://youtrack.jetbrains.com/issue/TW-48065 .

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Mar 30, 2017

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Mar 30, 2017

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Mar 30, 2017

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Mar 30, 2017

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Mar 30, 2017

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Mar 30, 2017

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Mar 30, 2017

Vladlis added a commit to Vladlis/checkstyle that referenced this issue Mar 30, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Apr 3, 2017

Member

New request to support: https://teamcity-support.jetbrains.com/hc/en-us/requests/919114

response from support:

Vladislav Rassokhin
Yesterday at 07:24

Hi Roman,

I'm trying to reproduce, debug and fix that problem locally.
Hopefully in release we wouldn't have that issue.
Sorry for inconvenience.
Will inform you once had more information.

Vladislav Rassokhin
Member

romani commented Apr 3, 2017

New request to support: https://teamcity-support.jetbrains.com/hc/en-us/requests/919114

response from support:

Vladislav Rassokhin
Yesterday at 07:24

Hi Roman,

I'm trying to reproduce, debug and fix that problem locally.
Hopefully in release we wouldn't have that issue.
Sorry for inconvenience.
Will inform you once had more information.

Vladislav Rassokhin
@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Apr 5, 2017

Member

I disabled TC triggers, I hope it will stop to appear in Github PR validations.

Member

romani commented Apr 5, 2017

I disabled TC triggers, I hope it will stop to appear in Github PR validations.

romani added a commit that referenced this issue Apr 5, 2017

@romani romani added the miscellaneous label Apr 5, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Apr 11, 2017

Member
Apr 10, 21:10 MSK
Hi Roman,

We've updated teamci­ty.jetbrains.com, now it uses IntelliJ IDEA 2016.2.5
 to run inspections & duplic­ates so problem with too many inspections 
should be solved.

Vladislav Rassokhin
Member

romani commented Apr 11, 2017

Apr 10, 21:10 MSK
Hi Roman,

We've updated teamci­ty.jetbrains.com, now it uses IntelliJ IDEA 2016.2.5
 to run inspections & duplic­ates so problem with too many inspections 
should be solved.

Vladislav Rassokhin
@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Apr 11, 2017

Member

All triggers are enabled in teamcity service

Member

romani commented Apr 11, 2017

All triggers are enabled in teamcity service

@Vladlis

This comment has been minimized.

Show comment
Hide comment
@Vladlis

Vladlis Apr 11, 2017

Member

I am on it

Member

Vladlis commented Apr 11, 2017

I am on it

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Apr 13, 2017

Member

@romani According to front page badge, TeamCity is now green and passing.
This issue is finished then, right?

Member

rnveach commented Apr 13, 2017

@romani According to front page badge, TeamCity is now green and passing.
This issue is finished then, right?

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Apr 13, 2017

Member

Yes, let's close it, ones it because problem again we could do reopen or create new issue with new status of validation.

Member

romani commented Apr 13, 2017

Yes, let's close it, ones it because problem again we could do reopen or create new issue with new status of validation.

@romani romani closed this Apr 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment