New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: use standalone shell files #3632

Closed
romani opened this Issue Dec 9, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@romani
Member

romani commented Dec 9, 2016

Create folder: .\ci\travis
place in it shell files that it is required to be launched by Travis.

Travis config need to be changed to work like:
https://github.com/checkstyle/sonar-checkstyle/blob/master/.travis.yml
https://github.com/checkstyle/sonar-checkstyle/blob/master/travis.sh

We can use travis.sh as single collector for commands that are simple.
Complicated commands should be created in separate shells.

Cons:

  • one CI, multiple files, and even separate folder for this.
  • mixture of files for CI and actual projects content in the same repo

Benefits:

  • User can run the same commands easily on their local
  • scripts become more userfirendly
  • it would be possible to use " in scripts, in string concatenation that does not work

Side notes:
github already kind of "forced" us to create ".guthub" folder , so we already have a mix.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Dec 9, 2016

Member

Just a note: Scripts will be shell and require windows users to install mingw or something similar to run them.

I think this is a good idea.

Member

rnveach commented Dec 9, 2016

Just a note: Scripts will be shell and require windows users to install mingw or something similar to run them.

I think this is a good idea.

@romani romani added the approved label Dec 9, 2016

romani added a commit that referenced this issue Dec 10, 2016

romani added a commit that referenced this issue Dec 10, 2016

romani added a commit that referenced this issue Dec 10, 2016

romani added a commit that referenced this issue Dec 11, 2016

romani added a commit that referenced this issue Dec 11, 2016

romani added a commit that referenced this issue Dec 12, 2016

romani added a commit that referenced this issue Dec 12, 2016

@romani romani added this to the 7.4 milestone Dec 12, 2016

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Dec 12, 2016

Member

all scripts were moved to travis.sh

Member

romani commented Dec 12, 2016

all scripts were moved to travis.sh

@romani romani closed this Dec 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment