New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactiring for RightCurlyCheck.java #3685

Closed
romani opened this Issue Jan 2, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@romani
Member

romani commented Jan 2, 2017

RightCurlyCheck.java

final String violation;
            if (shouldStartLine) {
                final String targetSourceLine = getLines()[rcurly.getLineNo() - 1];
                violation = validate(details, option, true, targetSourceLine);
            }
            else {
                violation = validate(details, option, false, "");
            }

Validate method should be only one (no overloads), targetSourceLine is depended on shouldStartLine
It should be also good to move this part of validation out of valudate method

@sagar-shah94

This comment has been minimized.

Show comment
Hide comment
@sagar-shah94

sagar-shah94 Mar 2, 2017

Contributor

I am on it.

Contributor

sagar-shah94 commented Mar 2, 2017

I am on it.

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 2, 2017

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 2, 2017

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 2, 2017

Issue #3685: Refactiring for RightCurlyCheck.java
Issue #3685: Extracted logic to function

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 2, 2017

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 2, 2017

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 2, 2017

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 2, 2017

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 3, 2017

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 6, 2017

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 6, 2017

# This is a combination of 2 commits.
# The first commit's message is:

Issue #3685: Refactoring for RightCurlyCheck.java

# This is the 2nd commit message:

changed logic

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 6, 2017

Merge remote-tracking branch 'origin/issue_3685' into issue_3685
 is:
Issue #3685: Refactoring for RightCurlyCheck.java

# This is the 2nd commit message:

changed logic

# This is the 3rd commit message:

Issue #3685: Refactoring for RightCurlyCheck.java

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 6, 2017

Issue #3685: Refactoring for RightCurlyCheck.java
changed logic

changed logic

final commit this

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 6, 2017

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 7, 2017

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 7, 2017

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 8, 2017

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 8, 2017

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 8, 2017

rnveach added a commit that referenced this issue Mar 13, 2017

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Mar 13, 2017

Member

Fix is merged

Member

rnveach commented Mar 13, 2017

Fix is merged

@rnveach rnveach closed this Mar 13, 2017

@rnveach rnveach added this to the 7.7 milestone Mar 13, 2017

Luolc added a commit to Luolc/checkstyle that referenced this issue Mar 13, 2017

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 18, 2017

GitToasterhub added a commit to GitToasterhub/checkstyle that referenced this issue Mar 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment