New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify tokens in checkstyle config #3720

Closed
rnveach opened this Issue Jan 12, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@rnveach
Member

rnveach commented Jan 12, 2017

We have a test to verify all modules are used in our config file.
We don't have a test to verify we are using all tokens. Some of our check specify a limited amount of tokens to be used on in our configuration. It is not clear if this is on purpose, we don't want to use the token, or if we forgot to add the token in a PR when it was introduced.
Some checks are also split into 2 or more instances, so it makes it harder to verify that all tokens are being used.

We need a test to verify this.
New test should verify all acceptable tokens for all checks are being used. If we don't want a token to be used at all, it should be listed in an override section.
If one check is split into multiple instances, the tokens from those instances should be combined into one and verified that way. We don't care how the tokens are being used in those split instances, just that we are using them all.

rnveach added a commit to rnveach/checkstyle that referenced this issue Jan 12, 2017

@romani romani added the approved label Jan 13, 2017

rnveach added a commit to rnveach/checkstyle that referenced this issue Jan 13, 2017

rnveach added a commit to rnveach/checkstyle that referenced this issue Jan 13, 2017

rnveach added a commit to rnveach/checkstyle that referenced this issue Jan 13, 2017

rnveach added a commit to rnveach/checkstyle that referenced this issue Jan 13, 2017

rnveach added a commit to rnveach/checkstyle that referenced this issue Jan 15, 2017

rnveach added a commit to rnveach/checkstyle that referenced this issue Jan 15, 2017

rnveach added a commit to rnveach/checkstyle that referenced this issue Jan 18, 2017

rnveach added a commit to rnveach/checkstyle that referenced this issue Jan 18, 2017

romani added a commit that referenced this issue Jan 18, 2017

@romani romani added this to the 7.5 milestone Jan 18, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jan 18, 2017

Member

fix is merged.

Member

romani commented Jan 18, 2017

fix is merged.

@romani romani closed this Jan 18, 2017

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Jan 18, 2017

Member

@romani Do we want to extend this validation to sevntu or google configurations?
We can also extend test to other properties.

Member

rnveach commented Jan 18, 2017

@romani Do we want to extend this validation to sevntu or google configurations?
We can also extend test to other properties.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jan 18, 2017

Member

@rnveach , lets try to do this, but each config in separate issues.

Member

romani commented Jan 18, 2017

@rnveach , lets try to do this, but each config in separate issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment