New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify tokens in google config #3740

Closed
rnveach opened this Issue Jan 18, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@rnveach
Member

rnveach commented Jan 18, 2017

Spinoff of Issue #3720

We are now verifying if tokens should or shouldn't be in our checkstyle configuration and we found some missing ones that we added in the mentioned issue.

We should extend this to check tokens in google's configuration.

New test should verify all acceptable tokens for all checks are being used. If we don't want a token to be used at all, it should be listed in an override section.

@romani romani added the approved label Jan 19, 2017

rnveach added a commit to rnveach/checkstyle that referenced this issue Jan 19, 2017

rnveach added a commit to rnveach/checkstyle that referenced this issue Jan 19, 2017

rnveach added a commit to rnveach/checkstyle that referenced this issue Jan 24, 2017

romani added a commit that referenced this issue Jan 24, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jan 24, 2017

Member

Mostly fixed.
There are few others issues created: #3748 , #3749 , #3752 , #3753 .

Member

romani commented Jan 24, 2017

Mostly fixed.
There are few others issues created: #3748 , #3749 , #3752 , #3753 .

@romani romani closed this Jan 24, 2017

@romani romani added this to the 7.5 milestone Jan 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment