New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RightCurly: handling of try-with-resources on several lines with CS 7.5 #3776

Closed
don-vip opened this Issue Jan 30, 2017 · 17 comments

Comments

Projects
None yet
4 participants
@don-vip
Contributor

don-vip commented Jan 30, 2017

/var/tmp $ javac Test.java

/var/tmp $ cat Test.java

// License: GPL. For details, see LICENSE file.
import java.io.BufferedReader;
import java.io.IOException;
class Test {

    void test() {
        try (BufferedReader br1 = new BufferedReader(null);
             BufferedReader br2 = new BufferedReader(br1)) {
            System.out.println("test");
        } catch (IOException e) {
            System.err.println(e);
        }
    }
}

/var/tmp $ cat config.xml

<?xml version="1.0"?>
<!DOCTYPE module PUBLIC
          "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
          "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
<module name="Checker">
    <property name="charset" value="UTF-8"/>
    <module name="TreeWalker">
        <module name="RightCurly"/>
    </module>
</module>

/var/tmp $ java -jar checkstyle-7.5-all.jar -c config.xml Test.java

Starting audit...
[WARN] C:\SVN\Test.java:8:58: '}' at column 58 should be on a new line. [RightCurly]
Audit done.


Checkstyle 7.4 did not raise error, and that's the behaviour we want.
http://checkstyle.sourceforge.net/config_blocks.html#RightCurly

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jan 30, 2017

Member

regression is confirmed, no violations on 7.4 .

looks like we lost smth at recent updates:
4cda256
2c81de1

Member

romani commented Jan 30, 2017

regression is confirmed, no violations on 7.4 .

looks like we lost smth at recent updates:
4cda256
2c81de1

@romani romani added the approved label Jan 30, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jan 30, 2017

Member

@don-vip , if you run checkstyle on open source project please share link to your code, we will add your project to our regression testing.

Member

romani commented Jan 30, 2017

@don-vip , if you run checkstyle on open source project please share link to your code, we will add your project to our regression testing.

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Jan 30, 2017

Member

This line broke regression: 4cda256#diff-9b2a5f9e69b254b923cb4fd7420cb9a4L178

try case is not getting the right and left curlies. Most likely it was not made for try-with-resources in mind. lcurly is RESOURCE_SPECIFICATION and rcurly is ). This explains why the violation position 8:58 is not where the brace is.

Member

rnveach commented Jan 30, 2017

This line broke regression: 4cda256#diff-9b2a5f9e69b254b923cb4fd7420cb9a4L178

try case is not getting the right and left curlies. Most likely it was not made for try-with-resources in mind. lcurly is RESOURCE_SPECIFICATION and rcurly is ). This explains why the violation position 8:58 is not where the brace is.

@asashour

This comment has been minimized.

Show comment
Hide comment
@asashour

asashour Jan 30, 2017

HtmlUnit is an open-source project, and faces the same issue.

Code in http://svn.code.sf.net/p/htmlunit/code/trunk/htmlunit/

asashour commented Jan 30, 2017

HtmlUnit is an open-source project, and faces the same issue.

Code in http://svn.code.sf.net/p/htmlunit/code/trunk/htmlunit/

@don-vip

This comment has been minimized.

Show comment
Hide comment
@don-vip

don-vip Jan 30, 2017

Contributor

Thank you! The project is there: https://josm.openstreetmap.de/svn/trunk/

The classes that provoque the error:

<file name="C:\SVN\josm\core\src\org\openstreetmap\josm\io\BoundingBoxDownloader.java">
<error line="169" column="72" severity="warning" message="&apos;}&apos; à la colonne 72 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
<error line="176" column="72" severity="warning" message="&apos;}&apos; à la colonne 72 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
<error line="188" column="72" severity="warning" message="&apos;}&apos; à la colonne 72 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
</file>
<file name="C:\SVN\josm\core\src\org\openstreetmap\josm\io\NoteExporter.java">
<error line="42" column="56" severity="warning" message="&apos;}&apos; à la colonne 56 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
</file>
<file name="C:\SVN\josm\core\src\org\openstreetmap\josm\io\imagery\ImageryReader.java">
<error line="86" column="40" severity="warning" message="&apos;}&apos; à la colonne 40 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
</file>
<file name="C:\SVN\josm\core\test\functional\org\openstreetmap\josm\data\osm\TaginfoTestIT.java">
<error line="55" column="55" severity="warning" message="&apos;}&apos; à la colonne 55 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
</file>
<file name="C:\SVN\josm\core\test\functional\org\openstreetmap\josm\io\MultiFetchServerObjectReaderTest.java">
<error line="183" column="10" severity="warning" message="&apos;}&apos; à la colonne 10 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
</file>
<file name="C:\SVN\josm\core\test\functional\org\openstreetmap\josm\io\OsmServerBackreferenceReaderTest.java">
<error line="195" column="10" severity="warning" message="&apos;}&apos; à la colonne 10 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
</file>
<file name="C:\SVN\josm\core\test\unit\org\openstreetmap\josm\data\AutosaveTaskTest.java">
<error line="193" column="113" severity="warning" message="&apos;}&apos; à la colonne 113 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
<error line="237" column="113" severity="warning" message="&apos;}&apos; à la colonne 113 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
</file>
<file name="C:\SVN\josm\core\test\unit\org\openstreetmap\josm\data\osm\NodeDataTest.java">
<error line="24" column="68" severity="warning" message="&apos;}&apos; à la colonne 68 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
</file>
<file name="C:\SVN\josm\core\test\unit\org\openstreetmap\josm\data\osm\WayDataTest.java">
<error line="27" column="68" severity="warning" message="&apos;}&apos; à la colonne 68 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
</file>
<file name="C:\SVN\josm\core\test\unit\org\openstreetmap\josm\data\projection\ProjectionRefTest.java">
<error line="101" column="83" severity="warning" message="&apos;}&apos; à la colonne 83 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
<error line="273" column="84" severity="warning" message="&apos;}&apos; à la colonne 84 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
</file>
<file name="C:\SVN\josm\core\test\unit\org\openstreetmap\josm\data\projection\ProjectionRegressionTest.java">
<error line="91" column="85" severity="warning" message="&apos;}&apos; à la colonne 85 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
<error line="121" column="41" severity="warning" message="&apos;}&apos; à la colonne 41 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
</file>
<file name="C:\SVN\josm\core\test\unit\org\openstreetmap\josm\data\validation\routines\DomainValidatorTestIT.java">
<error line="276" column="64" severity="warning" message="&apos;}&apos; à la colonne 64 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
</file>
Contributor

don-vip commented Jan 30, 2017

Thank you! The project is there: https://josm.openstreetmap.de/svn/trunk/

The classes that provoque the error:

<file name="C:\SVN\josm\core\src\org\openstreetmap\josm\io\BoundingBoxDownloader.java">
<error line="169" column="72" severity="warning" message="&apos;}&apos; à la colonne 72 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
<error line="176" column="72" severity="warning" message="&apos;}&apos; à la colonne 72 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
<error line="188" column="72" severity="warning" message="&apos;}&apos; à la colonne 72 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
</file>
<file name="C:\SVN\josm\core\src\org\openstreetmap\josm\io\NoteExporter.java">
<error line="42" column="56" severity="warning" message="&apos;}&apos; à la colonne 56 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
</file>
<file name="C:\SVN\josm\core\src\org\openstreetmap\josm\io\imagery\ImageryReader.java">
<error line="86" column="40" severity="warning" message="&apos;}&apos; à la colonne 40 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
</file>
<file name="C:\SVN\josm\core\test\functional\org\openstreetmap\josm\data\osm\TaginfoTestIT.java">
<error line="55" column="55" severity="warning" message="&apos;}&apos; à la colonne 55 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
</file>
<file name="C:\SVN\josm\core\test\functional\org\openstreetmap\josm\io\MultiFetchServerObjectReaderTest.java">
<error line="183" column="10" severity="warning" message="&apos;}&apos; à la colonne 10 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
</file>
<file name="C:\SVN\josm\core\test\functional\org\openstreetmap\josm\io\OsmServerBackreferenceReaderTest.java">
<error line="195" column="10" severity="warning" message="&apos;}&apos; à la colonne 10 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
</file>
<file name="C:\SVN\josm\core\test\unit\org\openstreetmap\josm\data\AutosaveTaskTest.java">
<error line="193" column="113" severity="warning" message="&apos;}&apos; à la colonne 113 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
<error line="237" column="113" severity="warning" message="&apos;}&apos; à la colonne 113 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
</file>
<file name="C:\SVN\josm\core\test\unit\org\openstreetmap\josm\data\osm\NodeDataTest.java">
<error line="24" column="68" severity="warning" message="&apos;}&apos; à la colonne 68 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
</file>
<file name="C:\SVN\josm\core\test\unit\org\openstreetmap\josm\data\osm\WayDataTest.java">
<error line="27" column="68" severity="warning" message="&apos;}&apos; à la colonne 68 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
</file>
<file name="C:\SVN\josm\core\test\unit\org\openstreetmap\josm\data\projection\ProjectionRefTest.java">
<error line="101" column="83" severity="warning" message="&apos;}&apos; à la colonne 83 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
<error line="273" column="84" severity="warning" message="&apos;}&apos; à la colonne 84 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
</file>
<file name="C:\SVN\josm\core\test\unit\org\openstreetmap\josm\data\projection\ProjectionRegressionTest.java">
<error line="91" column="85" severity="warning" message="&apos;}&apos; à la colonne 85 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
<error line="121" column="41" severity="warning" message="&apos;}&apos; à la colonne 41 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
</file>
<file name="C:\SVN\josm\core\test\unit\org\openstreetmap\josm\data\validation\routines\DomainValidatorTestIT.java">
<error line="276" column="64" severity="warning" message="&apos;}&apos; à la colonne 64 devrait être sur une nouvelle ligne." source="com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck"/>
</file>

@rnveach rnveach self-assigned this Jan 30, 2017

rnveach added a commit to rnveach/checkstyle that referenced this issue Jan 30, 2017

rnveach added a commit to rnveach/checkstyle that referenced this issue Jan 30, 2017

rnveach added a commit to rnveach/checkstyle that referenced this issue Jan 30, 2017

rnveach added a commit to rnveach/checkstyle that referenced this issue Jan 30, 2017

rnveach added a commit to rnveach/checkstyle that referenced this issue Jan 30, 2017

rnveach added a commit to rnveach/checkstyle that referenced this issue Jan 30, 2017

rnveach added a commit to rnveach/checkstyle that referenced this issue Jan 31, 2017

yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Jan 31, 2017

yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Jan 31, 2017

romani added a commit that referenced this issue Jan 31, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jan 31, 2017

Member

@asashour ,

At what version of your code have no violation ? trunk and latest release do have problems.
I can use your repo only if code has no validation errors.

$ svn export https://svn.code.sf.net/p/htmlunit/code/tags/HtmlUnit-2.24 htmlunit
..
$ cd htmlunit3/
$mvn checkstyle:check
...
[INFO] Starting audit...
[ERROR] ../temp/4/htmlunit3/src/test/java/com/gargoylesoftware/htmlunit/source/SVN.java:0: Missing package-info.java file. [JavadocPackage]
[ERROR] ../temp/4/htmlunit3/src/test/java/com/gargoylesoftware/htmlunit/gae/GAETestRunner.java:0: Missing package-info.java file. [JavadocPackage]
Audit done.
Member

romani commented Jan 31, 2017

@asashour ,

At what version of your code have no violation ? trunk and latest release do have problems.
I can use your repo only if code has no validation errors.

$ svn export https://svn.code.sf.net/p/htmlunit/code/tags/HtmlUnit-2.24 htmlunit
..
$ cd htmlunit3/
$mvn checkstyle:check
...
[INFO] Starting audit...
[ERROR] ../temp/4/htmlunit3/src/test/java/com/gargoylesoftware/htmlunit/source/SVN.java:0: Missing package-info.java file. [JavadocPackage]
[ERROR] ../temp/4/htmlunit3/src/test/java/com/gargoylesoftware/htmlunit/gae/GAETestRunner.java:0: Missing package-info.java file. [JavadocPackage]
Audit done.
@asashour

This comment has been minimized.

Show comment
Hide comment
@asashour

asashour Jan 31, 2017

Hi Roman,

Thanks for looking into this.

I have to disagree, we use Continuous Integration, and checkstyle:checkstyle is part of each and every build, it won't be green otherwise.

I believe you have local customization that fails HtmlUnit build, both locally on developers machines and on the build server, checkstyle passes.

Anyhow, I just committed the two package-info.java missing in the test package, hope it passes for you now, please let me know if not.

You can see the result of the build in here (login as guest).

Thanks a lot

asashour commented Jan 31, 2017

Hi Roman,

Thanks for looking into this.

I have to disagree, we use Continuous Integration, and checkstyle:checkstyle is part of each and every build, it won't be green otherwise.

I believe you have local customization that fails HtmlUnit build, both locally on developers machines and on the build server, checkstyle passes.

Anyhow, I just committed the two package-info.java missing in the test package, hope it passes for you now, please let me know if not.

You can see the result of the build in here (login as guest).

Thanks a lot

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jan 31, 2017

Member

@don-vip , I just added your project to our regression testing and your trunk pass on latest code
https://travis-ci.org/checkstyle/checkstyle/jobs/197120534#L9456

PR: #3783
There are no code changes from 7.5 release - https://github.com/checkstyle/checkstyle/commits/master

Did I miss smth in my commands to run checkstyle on your project ?

Member

romani commented Jan 31, 2017

@don-vip , I just added your project to our regression testing and your trunk pass on latest code
https://travis-ci.org/checkstyle/checkstyle/jobs/197120534#L9456

PR: #3783
There are no code changes from 7.5 release - https://github.com/checkstyle/checkstyle/commits/master

Did I miss smth in my commands to run checkstyle on your project ?

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jan 31, 2017

Member

@asashour , thanks for a fix, now it works.
please do a favor and move "7.4" version to properties of pom.xml this will allow me to change version from command line to simplify build execution on our side.

Member

romani commented Jan 31, 2017

@asashour , thanks for a fix, now it works.
please do a favor and move "7.4" version to properties of pom.xml this will allow me to change version from command line to simplify build execution on our side.

@asashour

This comment has been minimized.

Show comment
Hide comment
@asashour

asashour Jan 31, 2017

Done, thanks.

asashour commented Jan 31, 2017

Done, thanks.

romani added a commit that referenced this issue Jan 31, 2017

@don-vip

This comment has been minimized.

Show comment
Hide comment
@don-vip

don-vip Jan 31, 2017

Contributor

@romani "ant checkstyle" produces an output file called "checkstyle-josm.xml", is it parsed by your script or does it assume we print the errors on standard output? Also do you want us to remove the version number as well?

Contributor

don-vip commented Jan 31, 2017

@romani "ant checkstyle" produces an output file called "checkstyle-josm.xml", is it parsed by your script or does it assume we print the errors on standard output? Also do you want us to remove the version number as well?

romani added a commit that referenced this issue Feb 1, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Feb 1, 2017

Member

@don-vip , just let me know how can I fail the build.
Do you have CI for checkstyle ? How you control that there are no checkstyle violations in build ?

Also do you want us to remove the version number as well?

if you update your build.xml some how to make me change checkstyle version from command line it will be very helpful or any other simplification to avoid my changes of your sources.

Member

romani commented Feb 1, 2017

@don-vip , just let me know how can I fail the build.
Do you have CI for checkstyle ? How you control that there are no checkstyle violations in build ?

Also do you want us to remove the version number as well?

if you update your build.xml some how to make me change checkstyle version from command line it will be very helpful or any other simplification to avoid my changes of your sources.

@don-vip

This comment has been minimized.

Show comment
Hide comment
@don-vip

don-vip Feb 1, 2017

Contributor

@romani yes our Jenkins is configured to report Checkstyle violations, yo can see the trend here: https://josm.openstreetmap.de/jenkins/job/JOSM/jdk=JDK8/checkstyle/trendDetails/

I just have removed the version number in https://josm.openstreetmap.de/changeset/11524/josm/

Contributor

don-vip commented Feb 1, 2017

@romani yes our Jenkins is configured to report Checkstyle violations, yo can see the trend here: https://josm.openstreetmap.de/jenkins/job/JOSM/jdk=JDK8/checkstyle/trendDetails/

I just have removed the version number in https://josm.openstreetmap.de/changeset/11524/josm/

@don-vip

This comment has been minimized.

Show comment
Hide comment
@don-vip

don-vip Feb 1, 2017

Contributor

@romani you have to add "failOnViolation=true" argument in our build.xml when we call checkstyle target. Depending on if you want the violations on standard outputs or not, you will probably have to change the formattre as well.

Contributor

don-vip commented Feb 1, 2017

@romani you have to add "failOnViolation=true" argument in our build.xml when we call checkstyle target. Depending on if you want the violations on standard outputs or not, you will probably have to change the formattre as well.

yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Feb 1, 2017

yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Feb 1, 2017

yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Feb 1, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Feb 1, 2017

Member

@don-vip , it is better to do less changes to your code, I will parse output file.

But unfortunately I can not make Travis to analyze your repo, Very weird error

..
checkstyle:
[checkstyle] checkstyle version 7.6-SNAPSHOT
[checkstyle] compiled on Wed February 01 2017, 18:22 UTC
[checkstyle] 0) Adding 1443 files from directory /home/travis/build/checkstyle/checkstyle/openstreetmap/src/org/openstreetmap/josm
[checkstyle] 1) Adding 461 files from directory /home/travis/build/checkstyle/checkstyle/openstreetmap/test
[checkstyle] To locate the files took 168 ms.
[checkstyle] Running Checkstyle 7.6-SNAPSHOT on 1904 files
[checkstyle] Using configuration /home/travis/build/checkstyle/checkstyle/openstreetmap/tools/checkstyle/josm_checks.xml
./.ci/travis/travis.sh: line 5:  2563 Killed                  ant -v checkstyle

https://travis-ci.org/checkstyle/checkstyle/jobs/197385378#L418, and it works on my local (max memory usage is heapsize =1Gb, max usedheap=670Mb) .
capture-checkstyle-and-on-travis
Travis limit is 4G - https://docs.travis-ci.com/user/ci-environment/.

I did not use ANT foe long time... , I do not what to do with this.

Member

romani commented Feb 1, 2017

@don-vip , it is better to do less changes to your code, I will parse output file.

But unfortunately I can not make Travis to analyze your repo, Very weird error

..
checkstyle:
[checkstyle] checkstyle version 7.6-SNAPSHOT
[checkstyle] compiled on Wed February 01 2017, 18:22 UTC
[checkstyle] 0) Adding 1443 files from directory /home/travis/build/checkstyle/checkstyle/openstreetmap/src/org/openstreetmap/josm
[checkstyle] 1) Adding 461 files from directory /home/travis/build/checkstyle/checkstyle/openstreetmap/test
[checkstyle] To locate the files took 168 ms.
[checkstyle] Running Checkstyle 7.6-SNAPSHOT on 1904 files
[checkstyle] Using configuration /home/travis/build/checkstyle/checkstyle/openstreetmap/tools/checkstyle/josm_checks.xml
./.ci/travis/travis.sh: line 5:  2563 Killed                  ant -v checkstyle

https://travis-ci.org/checkstyle/checkstyle/jobs/197385378#L418, and it works on my local (max memory usage is heapsize =1Gb, max usedheap=670Mb) .
capture-checkstyle-and-on-travis
Travis limit is 4G - https://docs.travis-ci.com/user/ci-environment/.

I did not use ANT foe long time... , I do not what to do with this.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Feb 1, 2017

Member

openstreetmap integration to CI is moved to separate issue - #3786

Member

romani commented Feb 1, 2017

openstreetmap integration to CI is moved to separate issue - #3786

@romani romani added this to the 7.6 milestone Feb 1, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Feb 1, 2017

Member

fix is merged.

Member

romani commented Feb 1, 2017

fix is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment