New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split and Organize Checkstyle inputs by Test for WhitespaceAfterCheck #3897

Closed
romani opened this Issue Mar 2, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@romani
Member

romani commented Mar 2, 2017

subtask of #3891 .

do a copy of all test input files to separate folder for WhitespaceAfterCheck .
Not any other Check should use new inputs.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Mar 2, 2017

Member

pre-assigned to Pedro Portela .

Member

romani commented Mar 2, 2017

pre-assigned to Pedro Portela .

@Pedro12909

This comment has been minimized.

Show comment
Hide comment
@Pedro12909

Pedro12909 Mar 2, 2017

Contributor

Working on it!

Contributor

Pedro12909 commented Mar 2, 2017

Working on it!

@Pedro12909

This comment has been minimized.

Show comment
Hide comment
@Pedro12909

Pedro12909 Mar 3, 2017

Contributor

I'm struggling to figure out what I'm supposed to do to fix this issue. Could you provide me some clearance? Thanks in advance!

Contributor

Pedro12909 commented Mar 3, 2017

I'm struggling to figure out what I'm supposed to do to fix this issue. Could you provide me some clearance? Thanks in advance!

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Mar 3, 2017

Member

find UT file - WhitespaceAfterCheckTest
look for lines like "verify(configurationTestCast, getPath("InputWhitespace.java"), expected);"
you need to copy all input files to separate folder and name them as InputWhitespaceAfterXXXX. All that files should be in separate folder to let other check do not use them at all.

Member

romani commented Mar 3, 2017

find UT file - WhitespaceAfterCheckTest
look for lines like "verify(configurationTestCast, getPath("InputWhitespace.java"), expected);"
you need to copy all input files to separate folder and name them as InputWhitespaceAfterXXXX. All that files should be in separate folder to let other check do not use them at all.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Mar 8, 2017

Member

fix is merged.

Member

romani commented Mar 8, 2017

fix is merged.

@romani romani closed this Mar 8, 2017

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment