New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split and Organize Checkstyle inputs by Test for TypecastParenPad #3900

Closed
romani opened this Issue Mar 2, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@romani
Member

romani commented Mar 2, 2017

subtask of #3891 .

do a copy of all test input files to separate folder for TypecastParenPad.
Not any other Check should use new inputs.

@romani

This comment has been minimized.

Show comment
Hide comment

ps-sp added a commit to ps-sp/checkstyle that referenced this issue Mar 3, 2017

Issue #3900: Modified TypecastParenPadCheckTest.java to accommodate f…
…or the change in the location of test-resources the corresponding tests depend upon. The test-resources for those tests now reside at src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/TypecastParenPad. Also the corresponding test-resources had to be modified accordingly to overcome having duplicate classes
@ps-sp

This comment has been minimized.

Show comment
Hide comment
@ps-sp

ps-sp Mar 3, 2017

Collaborator

Kindly review the modifications I made and let me know if it'd be alright to make a pull request for it.

Collaborator

ps-sp commented Mar 3, 2017

Kindly review the modifications I made and let me know if it'd be alright to make a pull request for it.

ps-sp added a commit to ps-sp/checkstyle that referenced this issue Mar 4, 2017

rnveach added a commit that referenced this issue Mar 5, 2017

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Mar 5, 2017

Member

Fix is merged.

Member

rnveach commented Mar 5, 2017

Fix is merged.

@rnveach rnveach closed this Mar 5, 2017

@rnveach rnveach added this to the 7.7 milestone Mar 5, 2017

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment