New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommitValidationTest: add character limit to line #3910

Closed
rnveach opened this Issue Mar 4, 2017 · 14 comments

Comments

Projects
None yet
4 participants
@rnveach
Member

rnveach commented Mar 4, 2017

Taken from #3905 (comment):

We restrict commit messages to be 1 line to be concise, but we don't limit how long that line can be allowing users to create 400+ character messages.

CommitValidationTest needs to be modified to restrict the line length to 200 characters.

Rules message needs to be updated to show this new rule with it's own number when validation fails so users know how to correct the issue.

@sagar-shah94

This comment has been minimized.

Show comment
Hide comment
@sagar-shah94

sagar-shah94 Mar 4, 2017

Contributor

i am on it.

Contributor

sagar-shah94 commented Mar 4, 2017

i am on it.

@ps-sp

This comment has been minimized.

Show comment
Hide comment
@ps-sp

ps-sp Mar 4, 2017

Collaborator

On it

Collaborator

ps-sp commented Mar 4, 2017

On it

@sagar-shah94

This comment has been minimized.

Show comment
Hide comment
@sagar-shah94

sagar-shah94 Mar 4, 2017

Contributor

Already sent pull request

Contributor

sagar-shah94 commented Mar 4, 2017

Already sent pull request

@ps-sp

This comment has been minimized.

Show comment
Hide comment
@ps-sp

ps-sp Mar 4, 2017

Collaborator

kudos.

Collaborator

ps-sp commented Mar 4, 2017

kudos.

@sagar-shah94

This comment has been minimized.

Show comment
Hide comment
@sagar-shah94

sagar-shah94 Mar 4, 2017

Contributor

Thanks @ps-sp

Contributor

sagar-shah94 commented Mar 4, 2017

Thanks @ps-sp

@ps-sp

This comment has been minimized.

Show comment
Hide comment
@ps-sp

ps-sp Mar 4, 2017

Collaborator

I was almost done too man ! It hurts :P

Collaborator

ps-sp commented Mar 4, 2017

I was almost done too man ! It hurts :P

@sagar-shah94

This comment has been minimized.

Show comment
Hide comment
@sagar-shah94

sagar-shah94 Mar 4, 2017

Contributor

@ps-sp Sorry i did not know .when i commented i am on it .i did not see any comment that is why i commented.
Sorry :(

Contributor

sagar-shah94 commented Mar 4, 2017

@ps-sp Sorry i did not know .when i commented i am on it .i did not see any comment that is why i commented.
Sorry :(

@ps-sp

This comment has been minimized.

Show comment
Hide comment
@ps-sp

ps-sp Mar 4, 2017

Collaborator

NO ! You don't have to be sorry bro. You got it done before me so it's rightfully yours. Also, if it makes you feel better, I'd have made a PR even in spite of seeing your comment, if I had completed it before you that is ! 😋

Collaborator

ps-sp commented Mar 4, 2017

NO ! You don't have to be sorry bro. You got it done before me so it's rightfully yours. Also, if it makes you feel better, I'd have made a PR even in spite of seeing your comment, if I had completed it before you that is ! 😋

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Mar 4, 2017

Member

who first did "i am on it.", that user will be assignee and I expect fix from it, any racing will be rejected.

Member

romani commented Mar 4, 2017

who first did "i am on it.", that user will be assignee and I expect fix from it, any racing will be rejected.

romani added a commit that referenced this issue Mar 4, 2017

@romani romani added this to the 7.7 milestone Mar 4, 2017

@romani romani closed this Mar 4, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Mar 4, 2017

Member

fix is merged

Member

romani commented Mar 4, 2017

fix is merged

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Mar 4, 2017

Member

I am re-opening the issue. Rule number was added but no updates were done to the violation message to inform the user of this new rule.
See https://github.com/checkstyle/checkstyle/blob/master/src/test/java/com/puppycrawl/tools/checkstyle/internal/CommitValidationTest.java#L289

@sagar-shah94 since you did first update, can you finish this?

Member

rnveach commented Mar 4, 2017

I am re-opening the issue. Rule number was added but no updates were done to the violation message to inform the user of this new rule.
See https://github.com/checkstyle/checkstyle/blob/master/src/test/java/com/puppycrawl/tools/checkstyle/internal/CommitValidationTest.java#L289

@sagar-shah94 since you did first update, can you finish this?

@rnveach rnveach reopened this Mar 4, 2017

@sagar-shah94

This comment has been minimized.

Show comment
Hide comment
@sagar-shah94

sagar-shah94 Mar 4, 2017

Contributor

@rnveach doing it now

Contributor

sagar-shah94 commented Mar 4, 2017

@rnveach doing it now

@sagar-shah94

This comment has been minimized.

Show comment
Hide comment
@sagar-shah94

sagar-shah94 Mar 4, 2017

Contributor

@rnveach Sir added violation message please review and approve

Contributor

sagar-shah94 commented Mar 4, 2017

@rnveach Sir added violation message please review and approve

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 4, 2017

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 4, 2017

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 4, 2017

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 4, 2017

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 4, 2017

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 7, 2017

romani added a commit that referenced this issue Mar 8, 2017

@romani romani added the miscellaneous label Mar 8, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Mar 8, 2017

Member

fix is merged.

Member

romani commented Mar 8, 2017

fix is merged.

@romani romani closed this Mar 8, 2017

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment