CommitValidationTest: add character limit to line

[rnveach]

Taken from #3905 (comment):

We restrict commit messages to be 1 line to be concise, but we don't limit how long that line can be allowing users to create 400+ character messages.

CommitValidationTest needs to be modified to restrict the line length to 200 characters.

Rules message needs to be updated to show this new rule with it's own number when validation fails so users know how to correct the issue.

[sagar-shah94]

i am on it.

[voidfist]

On it

[sagar-shah94]

Already sent pull request

[voidfist]

kudos.

[sagar-shah94]

Thanks @PS-SP

[voidfist]

I was almost done too man ! It hurts :P

[sagar-shah94]

@PS-SP Sorry i did not know .when i commented i am on it .i did not see any comment that is why i commented.
Sorry :(

[voidfist]

NO ! You don't have to be sorry bro. You got it done before me so it's rightfully yours. Also, if it makes you feel better, I'd have made a PR even in spite of seeing your comment, if I had completed it before you that is ! 😋

[romani]

who first did "i am on it.", that user will be assignee and I expect fix from it, any racing will be rejected.

[romani]

fix is merged

[rnveach]

I am re-opening the issue. Rule number was added but no updates were done to the violation message to inform the user of this new rule.
See https://github.com/checkstyle/checkstyle/blob/master/src/test/java/com/puppycrawl/tools/checkstyle/internal/CommitValidationTest.java#L289

@sagar-shah94 since you did first update, can you finish this?

[sagar-shah94]

@rnveach doing it now

[sagar-shah94]

@rnveach Sir added violation message please review and approve

[romani]

fix is merged.