Split and Organize Checkstyle inputs by Test for NoLineWrap #3933

Closed
romani opened this Issue Mar 5, 2017 · 7 comments

Comments

Projects
None yet
5 participants
@romani
Member

romani commented Mar 5, 2017

subtask of #3891 .

do a copy of all test input files to separate folder for NoLineWrap .
Not any other Check should use new inputs.

@romani

This comment has been minimized.

Show comment
Hide comment
@divsidhu-26

This comment has been minimized.

Show comment
Hide comment
@divsidhu-26

divsidhu-26 Mar 5, 2017

I am on it.........

I am on it.........

divsidhu-26 added a commit to divsidhu-26/checkstyle that referenced this issue Mar 6, 2017

Issue #3933 : Modified the NoLineWrapCheck method to take input from …
…files from a subfolder in the difrectory and also added the input files to that subfolder.
@divsidhu-26

This comment has been minimized.

Show comment
Hide comment
@divsidhu-26

divsidhu-26 Mar 6, 2017

Please review the changes i made and let me know if they are okay to make a pull request.

Please review the changes i made and let me know if they are okay to make a pull request.

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Mar 6, 2017

Member

@divsidhu-26 make a PR and we review there as it keeps issue clean of implementation fixes.
I can tell you right now we are only expecting changes in NoLineWrapCheckTest and it's inputs. Not any other class.

Member

rnveach commented Mar 6, 2017

@divsidhu-26 make a PR and we review there as it keeps issue clean of implementation fixes.
I can tell you right now we are only expecting changes in NoLineWrapCheckTest and it's inputs. Not any other class.

divsidhu-26 added a commit to divsidhu-26/checkstyle that referenced this issue Mar 6, 2017

Issue #3933:Modified the NoLineWrapCheck method to take input from fi…
…les from a subfolder in the directory and also added the input files to that subfolder

divsidhu-26 added a commit to divsidhu-26/checkstyle that referenced this issue Mar 6, 2017

Issue #3933:Modified the NoLineWrapCheck method to take input from fi…
…les from a subfolder in the directory and also added the input files to that subfolder

divsidhu-26 added a commit to divsidhu-26/checkstyle that referenced this issue Mar 6, 2017

Issue #3933:Modified the NoLineWrapCheck method to take input from fi…
…les from a subfolder in the directory and also added the input files to that subfolder

divsidhu-26 added a commit to divsidhu-26/checkstyle that referenced this issue Mar 6, 2017

Issue #3933:Modified the NoLineWrapCheck method to take input from fi…
…les from a subfolder in the directory and also added the input files to that subfolder

divsidhu-26 added a commit to divsidhu-26/checkstyle that referenced this issue Mar 7, 2017

Issue "#3933":Modified the NoLineWrapCheck method to take input from …
…files from a subfolder in the directory and also added the input files to that subfolder

divsidhu-26 added a commit to divsidhu-26/checkstyle that referenced this issue Mar 7, 2017

Issue "#3933":Modified the NoLineWrapCheck method to take input from …
…files from a subfolder in the directory and also added the input files to that subfolder

divsidhu-26 added a commit to divsidhu-26/checkstyle that referenced this issue Mar 7, 2017

Issue #3933:Modified the NoLineWrapCheck method to take input from fi…
…les from a subfolder in the directory and also added the input files to that subfolder

divsidhu-26 added a commit to divsidhu-26/checkstyle that referenced this issue Mar 9, 2017

Issue #3933: Modified the NoLineWrapCheck method to take input from f…
…iles from a subfolder in the directory and also added the input files to that subfolder

divsidhu-26 added a commit to divsidhu-26/checkstyle that referenced this issue Mar 9, 2017

Issue #3933: Modified the NoLineWrapCheck method to take input from f…
…iles from a subfolder in the directory and also added the input files to that subfolder

divsidhu-26 added a commit to divsidhu-26/checkstyle that referenced this issue Mar 13, 2017

Issue #3933: Modified the NoLineWrapCheck method to take input from f…
…iles from a subfolder in the directory and also added the input files to that subfolder

divsidhu-26 added a commit to divsidhu-26/checkstyle that referenced this issue Mar 13, 2017

Issue #3933: Modified the NoLineWrapCheck method to take input from f…
…iles from a subfolder in the directory and also added the input files to that subfolder

divsidhu-26 added a commit to divsidhu-26/checkstyle that referenced this issue Mar 18, 2017

Issue #3933: Modified the NoLineWrapCheck method to take input from f…
…iles from a subfolder in the directory and also added input files to that subfolder

divsidhu-26 added a commit to divsidhu-26/checkstyle that referenced this issue Mar 20, 2017

Issue #3933: Modified the NoLineWrapCheck method to take input from f…
…iles from a subfolder in the directory and also added input files to that subfolder

divsidhu-26 added a commit to divsidhu-26/checkstyle that referenced this issue Mar 20, 2017

Issue #3933: Modified the NoLineWrapCheck method to take input from f…
…iles from a subfolder in the directory and also added input files to that subfolder

divsidhu-26 added a commit to divsidhu-26/checkstyle that referenced this issue Mar 20, 2017

Issue #3933: Modified the NoLineWrapCheck method to take input from f…
…iles from a subfolder in the directory and also added input files to that subfolder
@Kietzmann

This comment has been minimized.

Show comment
Hide comment
@Kietzmann

Kietzmann Apr 12, 2017

Contributor

May I deal with it?

Contributor

Kietzmann commented Apr 12, 2017

May I deal with it?

@Vladlis

This comment has been minimized.

Show comment
Hide comment
@Vladlis

Vladlis Apr 12, 2017

Member

@Kietzmann ,
After the May 1st : #3947 (comment)

Member

Vladlis commented Apr 12, 2017

@Kietzmann ,
After the May 1st : #3947 (comment)

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Apr 20, 2017

Member

fix is merged

Member

romani commented Apr 20, 2017

fix is merged

@romani romani closed this Apr 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment