New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split and Organize Checkstyle inputs by Test for MethodParamPad #3954

Closed
romani opened this Issue Mar 7, 2017 · 11 comments

Comments

Projects
None yet
4 participants
@romani
Member

romani commented Mar 7, 2017

subtask of #3891 .

do a copy of all test input files to separate folder for MethodParamPad
Not any other Check should use new inputs.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Mar 7, 2017

Member

Pre-assigned to abulfazahmadov

Member

romani commented Mar 7, 2017

Pre-assigned to abulfazahmadov

@GitToasterhub

This comment has been minimized.

Show comment
Hide comment
@GitToasterhub

GitToasterhub Mar 8, 2017

Contributor

I am on it

Contributor

GitToasterhub commented Mar 8, 2017

I am on it

@GitToasterhub

This comment has been minimized.

Show comment
Hide comment
@GitToasterhub

GitToasterhub Mar 9, 2017

Contributor

I created as it's stated in task, new folder in resource/check/whitespace/inputmethodparampad
and placed there 2 input files of MethodParamPadCheckTest, InputParamPad.java and InputWhitespaceAround.java respectively
Also I changed a bit in getPath() method ,to a new input files position,and I ran this test,I got 4 successful 3 failed with reason ( '(' is preceded with whitespace. )
I was trying to find out why 3 test are failed and get stuck a bit.Am I doing something wrong?Or I had missed something ?If you could help me somehow I would be thankful!

Contributor

GitToasterhub commented Mar 9, 2017

I created as it's stated in task, new folder in resource/check/whitespace/inputmethodparampad
and placed there 2 input files of MethodParamPadCheckTest, InputParamPad.java and InputWhitespaceAround.java respectively
Also I changed a bit in getPath() method ,to a new input files position,and I ran this test,I got 4 successful 3 failed with reason ( '(' is preceded with whitespace. )
I was trying to find out why 3 test are failed and get stuck a bit.Am I doing something wrong?Or I had missed something ?If you could help me somehow I would be thankful!

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Mar 10, 2017

Member

@GitToasterhub We can't tell what you have done until we see the PR. Most likely you changed the file when you moved/copied it.

new folder in resource/check/whitespace/inputmethodparampad

folder name should be methodparampad, input files should be InputMethodParamPad....

Member

rnveach commented Mar 10, 2017

@GitToasterhub We can't tell what you have done until we see the PR. Most likely you changed the file when you moved/copied it.

new folder in resource/check/whitespace/inputmethodparampad

folder name should be methodparampad, input files should be InputMethodParamPad....

@GitToasterhub

This comment has been minimized.

Show comment
Hide comment
@GitToasterhub

GitToasterhub Mar 10, 2017

Contributor

@rnveach Oh sure,I made folder not inputmethodparampad but methodinputparampad.I am trying to make pull request using step-by-step guide from here http://checkstyle.sourceforge.net/beginning_development.html

and unfortunately when I do git push origin my-new-check
I get the following:
remote: Permission to checkstyle/checkstyle.git denied to GitToasterhub.
fatal: unable to access 'https://GitToasterhub@github.com/checkstyle/checkstyle.git/': The requested URL returned error: 403

Contributor

GitToasterhub commented Mar 10, 2017

@rnveach Oh sure,I made folder not inputmethodparampad but methodinputparampad.I am trying to make pull request using step-by-step guide from here http://checkstyle.sourceforge.net/beginning_development.html

and unfortunately when I do git push origin my-new-check
I get the following:
remote: Permission to checkstyle/checkstyle.git denied to GitToasterhub.
fatal: unable to access 'https://GitToasterhub@github.com/checkstyle/checkstyle.git/': The requested URL returned error: 403

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Mar 10, 2017

Member

@GitToasterhub

fatal: unable to access 'https://GitToasterhub@github.com/checkstyle/checkstyle.git/':

When you cloned, the URL should be github.com/GitToasterhub/checkstyle.git. You will have to modify your remote or re-clone to fix the URL.

Member

rnveach commented Mar 10, 2017

@GitToasterhub

fatal: unable to access 'https://GitToasterhub@github.com/checkstyle/checkstyle.git/':

When you cloned, the URL should be github.com/GitToasterhub/checkstyle.git. You will have to modify your remote or re-clone to fix the URL.

@Vladlis

This comment has been minimized.

Show comment
Hide comment
@Vladlis

Vladlis Mar 10, 2017

Member

@GitToasterhub
you try to push directly to Checkstyle, but you actually need to:

  1. Make your own fork of Checkstyle.
  2. Clone your fork.
  3. Create branch in the cloned project.
  4. Make all neccesary changes.
  5. Make commit and push.
  6. Make pull request from your fork to Checkstyle.
Member

Vladlis commented Mar 10, 2017

@GitToasterhub
you try to push directly to Checkstyle, but you actually need to:

  1. Make your own fork of Checkstyle.
  2. Clone your fork.
  3. Create branch in the cloned project.
  4. Make all neccesary changes.
  5. Make commit and push.
  6. Make pull request from your fork to Checkstyle.

GitToasterhub added a commit to GitToasterhub/checkstyle that referenced this issue Mar 10, 2017

@GitToasterhub

This comment has been minimized.

Show comment
Hide comment
@GitToasterhub

GitToasterhub Mar 10, 2017

Contributor

@Vladlis Thanks ,your advices are very helpful! I finally made a pull request

Contributor

GitToasterhub commented Mar 10, 2017

@Vladlis Thanks ,your advices are very helpful! I finally made a pull request

@GitToasterhub

This comment has been minimized.

Show comment
Hide comment
@GitToasterhub

GitToasterhub Mar 10, 2017

Contributor

As I mentioned,7 tests are ran in MethodParamPadCheckTest,and 4 of them are successful 3 are failed.I simply copied classes InputMethodParamPad and InputWhiteSpaceAround to methodparampad folder,having not changed these 2 classes.I trying to explore what can be a problem but yet I am stuck,and I hope for your help.

Contributor

GitToasterhub commented Mar 10, 2017

As I mentioned,7 tests are ran in MethodParamPadCheckTest,and 4 of them are successful 3 are failed.I simply copied classes InputMethodParamPad and InputWhiteSpaceAround to methodparampad folder,having not changed these 2 classes.I trying to explore what can be a problem but yet I am stuck,and I hope for your help.

GitToasterhub added a commit to GitToasterhub/checkstyle that referenced this issue Mar 10, 2017

@GitToasterhub

This comment has been minimized.

Show comment
Hide comment
@GitToasterhub

GitToasterhub Mar 10, 2017

Contributor

@rnveach Thanks for help! You were right,intellij idea were modifying somehow the class,when I copied it.I copied it simply via notepad and then ran tests in IDEA and everything worked.PR is also ready,It's my first PR ,and I might have done something wrong,I renamed it to Issue #3954 .

Contributor

GitToasterhub commented Mar 10, 2017

@rnveach Thanks for help! You were right,intellij idea were modifying somehow the class,when I copied it.I copied it simply via notepad and then ran tests in IDEA and everything worked.PR is also ready,It's my first PR ,and I might have done something wrong,I renamed it to Issue #3954 .

GitToasterhub added a commit to GitToasterhub/checkstyle that referenced this issue Mar 10, 2017

GitToasterhub added a commit to GitToasterhub/checkstyle that referenced this issue Mar 11, 2017

GitToasterhub added a commit to GitToasterhub/checkstyle that referenced this issue Mar 11, 2017

GitToasterhub added a commit to GitToasterhub/checkstyle that referenced this issue Mar 11, 2017

GitToasterhub added a commit to GitToasterhub/checkstyle that referenced this issue Mar 11, 2017

GitToasterhub added a commit to GitToasterhub/checkstyle that referenced this issue Mar 11, 2017

GitToasterhub added a commit to GitToasterhub/checkstyle that referenced this issue Mar 11, 2017

GitToasterhub added a commit to GitToasterhub/checkstyle that referenced this issue Mar 11, 2017

GitToasterhub added a commit to GitToasterhub/checkstyle that referenced this issue Mar 11, 2017

GitToasterhub added a commit to GitToasterhub/checkstyle that referenced this issue Mar 11, 2017

GitToasterhub added a commit to GitToasterhub/checkstyle that referenced this issue Mar 11, 2017

GitToasterhub added a commit to GitToasterhub/checkstyle that referenced this issue Mar 12, 2017

GitToasterhub added a commit to GitToasterhub/checkstyle that referenced this issue Mar 13, 2017

GitToasterhub added a commit to GitToasterhub/checkstyle that referenced this issue Mar 13, 2017

GitToasterhub added a commit to GitToasterhub/checkstyle that referenced this issue Mar 13, 2017

rnveach added a commit that referenced this issue Mar 14, 2017

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Mar 14, 2017

Member

Fix is merged

Member

rnveach commented Mar 14, 2017

Fix is merged

@rnveach rnveach closed this Mar 14, 2017

@rnveach rnveach added this to the 7.7 milestone Mar 14, 2017

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment