New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove from Input files "Compilable with Java8" #3965

Closed
romani opened this Issue Mar 9, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@romani
Member

romani commented Mar 9, 2017

All files under https://github.com/checkstyle/checkstyle/tree/master/src/test/resources/com/puppycrawl/tools/checkstyle
should not have such comment "Compilable with Java8", whole checkstyle is on java8 already.
To avoid massive UTs updates for line numbers , new line should be added after imports.

@Luolc

This comment has been minimized.

Show comment
Hide comment
@Luolc

Luolc Mar 9, 2017

Contributor

Is that OK to just replace the comment with an empty line? That can be simply implemented by a plain replace operation. Or we may need the help of regular expression to do the replacement.

Contributor

Luolc commented Mar 9, 2017

Is that OK to just replace the comment with an empty line? That can be simply implemented by a plain replace operation. Or we may need the help of regular expression to do the replacement.

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Mar 9, 2017

Member

Is that OK to just replace the comment with an empty line?

Yes, empty line is fine.

We will leave how it be done by the person who does the PR. I am not sure on the variations of the comment.

Member

rnveach commented Mar 9, 2017

Is that OK to just replace the comment with an empty line?

Yes, empty line is fine.

We will leave how it be done by the person who does the PR. I am not sure on the variations of the comment.

Luolc added a commit to Luolc/checkstyle that referenced this issue Mar 9, 2017

@Luolc

This comment has been minimized.

Show comment
Hide comment
@Luolc

Luolc Mar 9, 2017

Contributor

@rnveach Got it.
I am on it :)

Contributor

Luolc commented Mar 9, 2017

@rnveach Got it.
I am on it :)

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Mar 9, 2017

Member

Empty line is NOT ok, files should not look weird in repo.

Member

romani commented Mar 9, 2017

Empty line is NOT ok, files should not look weird in repo.

Luolc added a commit to Luolc/checkstyle that referenced this issue Mar 9, 2017

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Mar 9, 2017

Member

new line should be added after imports
Empty line is NOT ok

My bad, I missed the idea of just putting the empty line after the imports.

Member

rnveach commented Mar 9, 2017

new line should be added after imports
Empty line is NOT ok

My bad, I missed the idea of just putting the empty line after the imports.

rnveach added a commit that referenced this issue Mar 10, 2017

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Mar 10, 2017

Member

Fix is merged

Member

rnveach commented Mar 10, 2017

Fix is merged

@rnveach rnveach closed this Mar 10, 2017

@rnveach rnveach added this to the 7.7 milestone Mar 10, 2017

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment