New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTs should not use ROOT locale when they test violation/error message #3989

Closed
romani opened this Issue Mar 13, 2017 · 2 comments

Comments

Projects
None yet
1 participant
@romani
Member

romani commented Mar 13, 2017

from #3896 and its PR.

Usage of ROOT in this cases will not do localization at all. It is not really a test for fully localized resources.

The reason of problem is that for this Tests using getCheckMessage from base test class(BaseCheckTestSupport), that do load of file as resource NOT as localized bundle. Checks to loading by ResourceBundle class that is why they are localized.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Mar 13, 2017

Member

Issue is assigned to @Luolc .

@Luolc , I pushed by draft/ugly experiment to fix - branch "i3896-locale-for-UTs" - https://github.com/checkstyle/checkstyle/tree/i3896-locale-for-UTs .
So I failed to load localized bundle .... smth is missed or done in wrong way in my code.
Please look at my fixes and make good solution.

Member

romani commented Mar 13, 2017

Issue is assigned to @Luolc .

@Luolc , I pushed by draft/ugly experiment to fix - branch "i3896-locale-for-UTs" - https://github.com/checkstyle/checkstyle/tree/i3896-locale-for-UTs .
So I failed to load localized bundle .... smth is missed or done in wrong way in my code.
Please look at my fixes and make good solution.

Luolc added a commit to Luolc/checkstyle that referenced this issue Mar 13, 2017

Luolc added a commit to Luolc/checkstyle that referenced this issue Mar 13, 2017

Luolc added a commit to Luolc/checkstyle that referenced this issue Mar 13, 2017

Luolc added a commit to Luolc/checkstyle that referenced this issue Mar 13, 2017

romani added a commit that referenced this issue Mar 14, 2017

@romani romani added this to the 7.7 milestone Mar 14, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Mar 14, 2017

Member

fix is merged, but there is continuation #4003

Member

romani commented Mar 14, 2017

fix is merged, but there is continuation #4003

@romani romani closed this Mar 14, 2017

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 18, 2017

GitToasterhub added a commit to GitToasterhub/checkstyle that referenced this issue Mar 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment