New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename STMT in BlockOption class to STATEMENT #4035

Closed
romani opened this Issue Mar 17, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@romani
Member

romani commented Mar 17, 2017

code https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/checks/blocks/BlockOption.java#L49

Message name was changed too from "block.noStmt" to "block.noStatement"

full word should be used.

@subkrish

This comment has been minimized.

Show comment
Hide comment
@subkrish

subkrish Jun 21, 2017

Contributor

Do changes have to be made to MSG_KEY_BLOCK_NO_STMT and change it to MSG_KEY_BLOCK_NO_STATEMENT in EmptyBlockCheck and the subsequent changes as well?

https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/checks/blocks/EmptyBlockCheck.java#L72

Contributor

subkrish commented Jun 21, 2017

Do changes have to be made to MSG_KEY_BLOCK_NO_STMT and change it to MSG_KEY_BLOCK_NO_STATEMENT in EmptyBlockCheck and the subsequent changes as well?

https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/checks/blocks/EmptyBlockCheck.java#L72

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jun 21, 2017

Member

EmptyBlockCheck and the subsequent changes as well?

yes, please.

Member

romani commented Jun 21, 2017

EmptyBlockCheck and the subsequent changes as well?

yes, please.

subkrish pushed a commit to subkrish/checkstyle that referenced this issue Jun 21, 2017

subkrish pushed a commit to subkrish/checkstyle that referenced this issue Jun 22, 2017

subkrish pushed a commit to subkrish/checkstyle that referenced this issue Jun 22, 2017

romani added a commit that referenced this issue Jun 23, 2017

@romani romani added this to the 8.0 milestone Jun 23, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jun 23, 2017

Member

fix is merged

Member

romani commented Jun 23, 2017

fix is merged

@romani romani closed this Jun 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment