Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename STMT in BlockOption class to STATEMENT #4035

Closed
romani opened this issue Mar 17, 2017 · 3 comments
Closed

rename STMT in BlockOption class to STATEMENT #4035

romani opened this issue Mar 17, 2017 · 3 comments

Comments

@romani
Copy link
Member

romani commented Mar 17, 2017

code https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/checks/blocks/BlockOption.java#L49

Message name was changed too from "block.noStmt" to "block.noStatement"

full word should be used.

@subkrish
Copy link
Contributor

subkrish commented Jun 21, 2017

Do changes have to be made to MSG_KEY_BLOCK_NO_STMT and change it to MSG_KEY_BLOCK_NO_STATEMENT in EmptyBlockCheck and the subsequent changes as well?

https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/checks/blocks/EmptyBlockCheck.java#L72

@romani
Copy link
Member Author

romani commented Jun 21, 2017

EmptyBlockCheck and the subsequent changes as well?

yes, please.

@romani
Copy link
Member Author

romani commented Jun 23, 2017

fix is merged

@romani romani closed this as completed Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants