New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split and Organize Checkstyle inputs by Test for MethodLength #4042

Closed
romani opened this Issue Mar 18, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@romani
Member

romani commented Mar 18, 2017

subtask of #3891 .

do a copy of all test input files to separate folder for MethodLength .
Not any other Check should use new inputs.

@GabrielBercaru

This comment has been minimized.

Show comment
Hide comment
@GabrielBercaru

GabrielBercaru Mar 19, 2017

Contributor

Is this issue pre-assigned to someone or anyone could start working on it?

Contributor

GabrielBercaru commented Mar 19, 2017

Is this issue pre-assigned to someone or anyone could start working on it?

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Mar 19, 2017

Member

@GabrielBercaru , no, you can take it.

Member

romani commented Mar 19, 2017

@GabrielBercaru , no, you can take it.

@GabrielBercaru

This comment has been minimized.

Show comment
Hide comment
@GabrielBercaru

GabrielBercaru Mar 20, 2017

Contributor

I am on it.

Contributor

GabrielBercaru commented Mar 20, 2017

I am on it.

@GabrielBercaru

This comment has been minimized.

Show comment
Hide comment
@GabrielBercaru

GabrielBercaru Mar 21, 2017

Contributor

Since the input files "InputModifier.java" and "InputSimple.java" are used by multiple check test files, should I copy them inside a new directory "methodlength" and also keep the old ones inside "sizes" package? Should I dupilicate them or should I update all the check test files that use those files?

Contributor

GabrielBercaru commented Mar 21, 2017

Since the input files "InputModifier.java" and "InputSimple.java" are used by multiple check test files, should I copy them inside a new directory "methodlength" and also keep the old ones inside "sizes" package? Should I dupilicate them or should I update all the check test files that use those files?

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Mar 21, 2017

Member

@GabrielBercaru You should copy them to new directory and leave old ones where they are.

Member

rnveach commented Mar 21, 2017

@GabrielBercaru You should copy them to new directory and leave old ones where they are.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Mar 23, 2017

Member

fix is merged

Member

romani commented Mar 23, 2017

fix is merged

@romani romani closed this Mar 23, 2017

GitToasterhub added a commit to GitToasterhub/checkstyle that referenced this issue Mar 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment