New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SingleLineJavadoc update for new requirements what tags are allowed in singleline javadoc #4052
Comments
Hey guys, we have false positives with google-java-format and default google_checks.xml config.
So that means current solution/workaround is to remove Have you got any plans to update google_checks.xml in master? Thank you in advance! |
Issue is approved, we just wait for smb to fix it. Please send PR , we will guide you on all required changes.
Yes. It will work to make a workaround on your side. |
I am on it. |
fix is merged |
parent issue - #3888
guide update - google/styleguide@594d91b#diff-b6c9191ee5ccb7a5ef170e98e51d94d8L1084
http://checkstyle.sourceforge.net/config_javadoc.html#SingleLineJavadoc
we already have property -
ignoredTags
and it is null by default so no block tags are allowed.ignoreInlineTags
- is true by default.We need to change our google config to ignore inline tags (switch to default by removing
ignoreInlineTags
).current code:
checkstyle/src/main/resources/google_checks.xml
Lines 343 to 345 in 14005e3
definition of "block tags" (exact list of them) - http://docs.oracle.com/javase/8/docs/technotes/tools/windows/javadoc.html#CHDBEFIF (for java7)
Lets save this link in xdoc to explain user meaning of such terms.
lets do updates for our IT inputs, case from #3762 should be added too.
Current behavior:
Expected: no violations.
The text was updated successfully, but these errors were encountered: