New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split and Organize Checkstyle inputs by Test for ParentPad #4062

Closed
sabaka opened this Issue Mar 20, 2017 · 8 comments

Comments

Projects
None yet
5 participants
@sabaka
Contributor

sabaka commented Mar 20, 2017

subtask of #3891 .

do a copy of all test input files to separate folder for ParentPad .
Not any other Check should use new inputs.

@sabaka

This comment has been minimized.

Show comment
Hide comment
@sami5596

This comment has been minimized.

Show comment
Hide comment
@sami5596

sami5596 Mar 20, 2017

I am on it

I am on it

@sami5596

This comment has been minimized.

Show comment
Hide comment
@sami5596

sami5596 Mar 20, 2017

Can you also provide me with a brief explanation of the issue?

Can you also provide me with a brief explanation of the issue?

@sami5596

This comment has been minimized.

Show comment
Hide comment
@sami5596

sami5596 Mar 20, 2017

If we are to organize the checkstyle inputs by test for ParenPad then we should start by making a directory for one single test like for example, for ParenPad if test name is ParenPadCheckTest then the directory would be
.../checks/design/ParenPad/
This directory will contain the ParenPadCheckTest as well as another directory i.e. Inputs
.../checks/design/ParenPad/Inputs
This directory will contain all the inputs that are to be used by the ParenPadCheckTest.

Now if we want to organize the inputs for the test in the Inputs folders we should simply rename the inputs as
Input_[AnyIdentifier]
[] are just used for an example and should not be used in the final name of the input.

Instead of [AnyIdentifier], we can use an ID or keep different names for different inputs in order to differentiate them from other inputs that are to be used by ParenPadCheckTest.

Once we have renamed the inputs for ParenPadCheckTest, we should start naming all the future inputs in the similar manner so that all required inputs for a test are kept together in one place.

sami5596 commented Mar 20, 2017

If we are to organize the checkstyle inputs by test for ParenPad then we should start by making a directory for one single test like for example, for ParenPad if test name is ParenPadCheckTest then the directory would be
.../checks/design/ParenPad/
This directory will contain the ParenPadCheckTest as well as another directory i.e. Inputs
.../checks/design/ParenPad/Inputs
This directory will contain all the inputs that are to be used by the ParenPadCheckTest.

Now if we want to organize the inputs for the test in the Inputs folders we should simply rename the inputs as
Input_[AnyIdentifier]
[] are just used for an example and should not be used in the final name of the input.

Instead of [AnyIdentifier], we can use an ID or keep different names for different inputs in order to differentiate them from other inputs that are to be used by ParenPadCheckTest.

Once we have renamed the inputs for ParenPadCheckTest, we should start naming all the future inputs in the similar manner so that all required inputs for a test are kept together in one place.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Mar 21, 2017

Member

please look at commit 7fc36c4 , there are bunch of similar issues fixed and merged, so please look at them as example .

Member

romani commented Mar 21, 2017

please look at commit 7fc36c4 , there are bunch of similar issues fixed and merged, so please look at them as example .

@Kietzmann

This comment has been minimized.

Show comment
Hide comment
@Kietzmann

Kietzmann Apr 19, 2017

Contributor

@sabaka
Could you please approve this issue to pass my pull request by CI?
Thanks

Contributor

Kietzmann commented Apr 19, 2017

@sabaka
Could you please approve this issue to pass my pull request by CI?
Thanks

@rnveach rnveach added the approved label Apr 19, 2017

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Apr 19, 2017

Member

issue approved

Member

rnveach commented Apr 19, 2017

issue approved

romani added a commit that referenced this issue Apr 20, 2017

@romani romani added this to the 7.7 milestone Apr 20, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Apr 20, 2017

Member

fix is merged

Member

romani commented Apr 20, 2017

fix is merged

@romani romani closed this Apr 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment