New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WhitespaceAround: Add support for varargs #4157

Closed
pbludov opened this Issue Apr 5, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@pbludov
Collaborator

pbludov commented Apr 5, 2017

$ javac Test.java
$ cat Test.java

public class Test {
    public static void main(String... args) {} // Would like to have a violation here
}

Actually, we need opposite of #3718

@samuel-gu

This comment has been minimized.

Show comment
Hide comment
@samuel-gu

samuel-gu Apr 7, 2017

Contributor

I'm on it

Contributor

samuel-gu commented Apr 7, 2017

I'm on it

sergileon added a commit to sergileon/checkstyle that referenced this issue Sep 5, 2017

sergileon added a commit to sergileon/checkstyle that referenced this issue Sep 5, 2017

sergileon added a commit to sergileon/checkstyle that referenced this issue Sep 5, 2017

@sergileon

This comment has been minimized.

Show comment
Hide comment
@sergileon

sergileon Sep 5, 2017

Contributor

I think what
public class Test { public static void main(String... args) { } // No violation }
public class Test { public static void main(String ... args) { } // violation }
All right?

Contributor

sergileon commented Sep 5, 2017

I think what
public class Test { public static void main(String... args) { } // No violation }
public class Test { public static void main(String ... args) { } // violation }
All right?

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Sep 5, 2017

Member

No, completely opposite.
WhitespaceAround demand spaces around token.
User wants to add this token to allowed tokens of this Check to enforce spaces around '...' .

This token should not be default.

Member

romani commented Sep 5, 2017

No, completely opposite.
WhitespaceAround demand spaces around token.
User wants to add this token to allowed tokens of this Check to enforce spaces around '...' .

This token should not be default.

sergileon added a commit to epam/checkstyle that referenced this issue Sep 13, 2017

sergileon added a commit to epam/checkstyle that referenced this issue Sep 13, 2017

sergileon added a commit to epam/checkstyle that referenced this issue Sep 13, 2017

@romani romani closed this in #5107 Sep 14, 2017

romani added a commit that referenced this issue Sep 14, 2017

@romani romani added the new feature label Sep 14, 2017

@romani romani added this to the 8.3 milestone Sep 14, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Sep 14, 2017

Member

fix is merged

Member

romani commented Sep 14, 2017

fix is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment