New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split and Organize Checkstyle inputs by Test for checks in coding package #4165

Closed
Vladlis opened this Issue Apr 6, 2017 · 16 comments

Comments

Projects
None yet
4 participants
@Vladlis
Member

Vladlis commented Apr 6, 2017

subtask of #3891

move / do a copy of all test input files to a separate folder for all checks in coding package.
Not any other Check should use new inputs.

@Vladlis

This comment has been minimized.

Show comment
Hide comment
@Vladlis

Vladlis Apr 6, 2017

Member

@izishared
Please help us with this issue (as you said here)

Member

Vladlis commented Apr 6, 2017

@izishared
Please help us with this issue (as you said here)

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Apr 6, 2017

Member

each Check/Test should be done in separate PR, multiple PRs are expected.
Do not do all at ones!

Member

romani commented Apr 6, 2017

each Check/Test should be done in separate PR, multiple PRs are expected.
Do not do all at ones!

@Vladlis

This comment has been minimized.

Show comment
Hide comment
@Vladlis

Vladlis Apr 6, 2017

Member

@romani ,
why not combine few commits in PR? but with a separate commit for each Check?

Could you also approve this issue?

Member

Vladlis commented Apr 6, 2017

@romani ,
why not combine few commits in PR? but with a separate commit for each Check?

Could you also approve this issue?

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Apr 6, 2017

Member

new contributors have problems to make correct update for one Check , for some of them it takes few weeks. I wish @izishared could impress me , but I doubt. Verification of big PR is also time consuming task.

Member

romani commented Apr 6, 2017

new contributors have problems to make correct update for one Check , for some of them it takes few weeks. I wish @izishared could impress me , but I doubt. Verification of big PR is also time consuming task.

izishared added a commit to izishared/checkstyle that referenced this issue Apr 11, 2017

izishared added a commit to izishared/checkstyle that referenced this issue Apr 11, 2017

izishared added a commit to izishared/checkstyle that referenced this issue Apr 11, 2017

izishared added a commit to izishared/checkstyle that referenced this issue Apr 11, 2017

izishared added a commit to izishared/checkstyle that referenced this issue Apr 11, 2017

izishared added a commit to izishared/checkstyle that referenced this issue Apr 11, 2017

romani added a commit that referenced this issue Apr 11, 2017

@romani romani added this to the 7.7 milestone Apr 11, 2017

@romani romani closed this Apr 11, 2017

@romani romani reopened this Apr 11, 2017

romani added a commit that referenced this issue Apr 11, 2017

romani added a commit that referenced this issue Apr 12, 2017

romani added a commit that referenced this issue Apr 12, 2017

izishared added a commit to izishared/checkstyle that referenced this issue Apr 12, 2017

izishared added a commit to izishared/checkstyle that referenced this issue Apr 12, 2017

izishared added a commit to izishared/checkstyle that referenced this issue Apr 12, 2017

izishared added a commit to izishared/checkstyle that referenced this issue Apr 12, 2017

romani added a commit that referenced this issue Apr 12, 2017

romani added a commit that referenced this issue Apr 12, 2017

romani added a commit that referenced this issue Apr 12, 2017

romani added a commit that referenced this issue Apr 12, 2017

izishared added a commit to izishared/checkstyle that referenced this issue Apr 13, 2017

izishared added a commit to izishared/checkstyle that referenced this issue Apr 13, 2017

izishared added a commit to izishared/checkstyle that referenced this issue Apr 13, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

Issue #4165: Split and Organize Checkstyle inputs by Test for checks …
…in coding package: MultipleVariableDeclarations

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

timurt added a commit to timurt/checkstyle that referenced this issue May 6, 2017

@Vladlis

This comment has been minimized.

Show comment
Hide comment
Member

Vladlis commented May 15, 2017

@Kietzmann

This comment has been minimized.

Show comment
Hide comment
@Kietzmann

Kietzmann May 15, 2017

Contributor

@Vladlis
I'll try to do it ASAP

Contributor

Kietzmann commented May 15, 2017

@Vladlis
I'll try to do it ASAP

@Kietzmann

This comment has been minimized.

Show comment
Hide comment
Contributor

Kietzmann commented May 16, 2017

Kietzmann added a commit to Kietzmann/checkstyle that referenced this issue May 16, 2017

romani added a commit that referenced this issue May 16, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani May 16, 2017

Member

@Vladlis , was it last change for this issue ?

Member

romani commented May 16, 2017

@Vladlis , was it last change for this issue ?

@Kietzmann

This comment has been minimized.

Show comment
Hide comment
@Kietzmann

Kietzmann May 16, 2017

Contributor

@Vladlis
Fixed in #4360

Contributor

Kietzmann commented May 16, 2017

@Vladlis
Fixed in #4360

rnveach added a commit that referenced this issue May 16, 2017

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach May 16, 2017

Member

@Vladlis we good now?

Member

rnveach commented May 16, 2017

@Vladlis we good now?

@Vladlis

This comment has been minimized.

Show comment
Hide comment
@Vladlis

Vladlis May 17, 2017

Member

@rnveach, yes, all inputs seem to be moved in appropriate packages and properly renamed.

@Kietzmann, thanks!

Member

Vladlis commented May 17, 2017

@rnveach, yes, all inputs seem to be moved in appropriate packages and properly renamed.

@Kietzmann, thanks!

@Vladlis Vladlis closed this May 17, 2017

@Vladlis Vladlis modified the milestones: 7.8, 7.7 May 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment